Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Add spaces as a new WebDAV url type #39599

Merged
merged 1 commit into from
Dec 20, 2021
Merged

[tests-only] Add spaces as a new WebDAV url type #39599

merged 1 commit into from
Dec 20, 2021

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Dec 15, 2021 •
edited
Loading

Description

  • added support for spaces WebDAV type in e2e test scenarios
  • uses acceptance-test-changes-waiting-2021-11 as base branch

Related Issue

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@kiranparajuli589 kiranparajuli589 self-assigned this Dec 15, 2021
@kiranparajuli589 kiranparajuli589 marked this pull request as draft December 15, 2021 12:18
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiComments-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34044/51/1

@kiranparajuli589 kiranparajuli589 force-pushed the space-as-new-webdav branch 2 times, most recently from aec7caf to 4e98e82 Compare December 16, 2021 06:56
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiWebdavPreviews-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34048/95/1

@kiranparajuli589 kiranparajuli589 force-pushed the space-as-new-webdav branch 3 times, most recently from f225e42 to 2898b6c Compare December 17, 2021 07:56
@kiranparajuli589 kiranparajuli589 changed the base branch from master to acceptance-test-changes-waiting-2021-11 December 17, 2021 07:58
@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review December 17, 2021 09:39
saw-jan
saw-jan reviewed Dec 17, 2021
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

SwikritiT
SwikritiT reviewed Dec 20, 2021
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phil-davis phil-davis marked this pull request as draft December 20, 2021 04:18
@phil-davis
Copy link
Contributor

Converted to draft. I will review and cherry-pick into #39514 this morning.

phil-davis
phil-davis reviewed Dec 20, 2021
View reviewed changes
tests/acceptance/features/bootstrap/FeatureContext.php
Comment on lines +2552 to +2553
// assuming the first space is the personal space
return $json->value[0]->id;
Copy link
Contributor

@phil-davis phil-davis Dec 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the next iteration we should double-check that the space is "personal". For now, these tests are only running in an environment that has a personal space.

@kiranparajuli589 if you need to make other core changes for this, then also add some code here to make sure that a personal space is returned.

@phil-davis phil-davis marked this pull request as ready for review December 20, 2021 11:19
@phil-davis phil-davis merged commit 62511ca into acceptance-test-changes-waiting-2021-11 Dec 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the space-as-new-webdav branch December 20, 2021 11:19
This was referenced Dec 20, 2021
Closed
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Jan 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT left review comments

@saw-jan saw-jan saw-jan left review comments

@phil-davis phil-davis phil-davis approved these changes

@dpakach dpakach Awaiting requested review from dpakach

@Talank Talank Awaiting requested review from Talank

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add spaces WebDAV URL as a third variant for WebDAV path
5 participants
@kiranparajuli589 @ownclouders @phil-davis @SwikritiT @saw-jan