Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only]Add bug demonstration test for sending PUT request to other user's webdav endpoint #39598

Closed
wants to merge 1 commit into from
Closed

[tests-only]Add bug demonstration test for sending PUT request to other user's webdav endpoint #39598

wants to merge 1 commit into from

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Dec 15, 2021 •
edited
Loading

Description

This PR adds bug demonstration tests for sending PUT request to other user's webdav endpoint

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@SwikritiT SwikritiT self-assigned this Dec 15, 2021
@SwikritiT SwikritiT mentioned this pull request Dec 15, 2021
Merged
9 tasks
@SwikritiT SwikritiT force-pushed the bug-demo-test-webdav-put branch from 8f0575d to 0b39f2b Compare December 15, 2021 06:12
@SwikritiT SwikritiT requested a review from phil-davis December 15, 2021 06:12
@SwikritiT SwikritiT force-pushed the bug-demo-test-webdav-put branch from 0b39f2b to b84df09 Compare December 15, 2021 08:31
phil-davis
phil-davis approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The "good" test is the way that all implementations should behave (403 status)

@owncloud owncloud deleted a comment from ownclouders Dec 15, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor

I have cherry-picked this to #39514 where we are putting test changes while release-10.9.0 is happening.

@SwikritiT
Copy link
Contributor Author

I have cherry-picked this to #39514 where we are putting test changes while release-10.9.0 is happening.

I'll bump the commit id's now.

@SwikritiT SwikritiT mentioned this pull request Dec 15, 2021
Merged
@phil-davis
Copy link
Contributor

CI passed. The code is in #39514 - closing here.

@phil-davis phil-davis closed this Dec 15, 2021
@SwikritiT SwikritiT mentioned this pull request Dec 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SwikritiT @phil-davis