[tests-only]Fixed flaky test detected in files_classifiers

[Talank]

Description

after some debugging the test scenario apiSharePublicLink2/copyFromPublicLinkOc10Issue37683.feature:9 that was failing in files_classifiers is turned out to be order dependent. And we can make the test pass by swapping the steps to check content in original and copied file.

Related Issue

• Fixes https://github.com/owncloud/files_classifier/issues/537

How Has This Been Tested?

• 🤖

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[ownclouders]

💥 Acceptance tests pipeline webUIUpload-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33888/150/1

[phil-davis]

Note:

1. we added an extra check that "/PARENT/copy1.txt" is definitely no longer a file, after it has been overwritten by a folder. That is an enhancement to the scenario, not directly fixing the flaky behavior. (see comment below - this extra step was not useful)

2. the order of checking the content of the 2 copies of testfile.txt has been changed. That seems to eliminate the flaky behavior in the files_classifier CI. TBH we are not sure why this really helps. But it will be good to get this scenario "happy".

[phil-davis]

Unrelated fail https://drone.owncloud.com/owncloud/core/33888/150/16
I raised issue #39549 and restarted CI.

[ownclouders]

💥 Acceptance tests pipeline apiSharePublicLink2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33890/72/1

[ownclouders]

💥 Acceptance tests pipeline apiSharePublicLink2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33892/72/1

[phil-davis]

https://drone.owncloud.com/owncloud/core/33892/72/13

And as "Alice" file "/PARENT/copy1.txt" should not exist
file '/PARENT/copy1.txt' should not exist. But it does exist and is a folder

Actually it is probably best that that step works in that way.
The step before is:

And as "Alice" folder "/PARENT/copy1.txt" should exist

That already checks that the resource is a folder, so we already know that it is not a file.

I will remove that extra test step that does not do anything useful.

[ownclouders]

💥 Acceptance tests pipeline webUIUpload-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33897/150/1

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[phil-davis]

This has been cherry-picked into PR #39548