Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement quick action for creating public links #39130

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Implement quick action for creating public links #39130

merged 1 commit into from
Aug 31, 2021

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Aug 23, 2021 •
edited
Loading

Description

Can be enabled by setting 'sharing.showPublicLinkQuickAction' => true in your config.php.

To-Dos:

  • Basic implementation
  • Hide option when sharing is disabled for certain groups
  • Implement synergy with whitelisting
  • Ignore when password enforcement policies are active (+ info in config)
  • Tests
  • Changelog
  • Doc ticket
  • Create patch with translations

Related Issue

Screenshots

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

@JammingBen JammingBen self-assigned this Aug 23, 2021
@JammingBen JammingBen force-pushed the public-link-button branch 2 times, most recently from 8f182d9 to 9dd9aaa Compare August 24, 2021 09:16
@owncloud owncloud deleted a comment from update-docs bot Aug 24, 2021
@JammingBen JammingBen mentioned this pull request Aug 25, 2021
Closed
12 tasks
@JammingBen JammingBen marked this pull request as ready for review August 25, 2021 07:08
@owncloud owncloud deleted a comment from ownclouders Aug 25, 2021
@owncloud owncloud deleted a comment from ownclouders Aug 25, 2021
@mrow4a mrow4a mentioned this pull request Aug 25, 2021
Merged
@phil-davis
Copy link
Contributor

Can be enabled by setting 'sharing.showPublicLinkQuickAction' => false in your config.php.

That seems very strange to me. Why would you set it to false to enable it?

@JammingBen
Copy link
Contributor Author

That seems very strange to me. Why would you set it to false to enable it?

Haha yeah, just a spelling mistake 😄 Thanks for the hint though!

@phil-davis phil-davis mentioned this pull request Aug 25, 2021
Closed
@phil-davis
Copy link
Contributor

I raised issue #39132 to add a few acceptance test cases. If others think this PR is good, the acceptance tests can be added in a separate PR after merging this.

AlexAndBear
AlexAndBear approved these changes Aug 30, 2021
View reviewed changes
Copy link

@AlexAndBear AlexAndBear left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 🚀 🌔

phil-davis
phil-davis approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works - there is a separate issue to create an acceptance test scenario, which will come later separately.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

56.7% 56.7% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 63d47c1 into master Aug 31, 2021
@JammingBen JammingBen mentioned this pull request Sep 3, 2021
Merged
11 tasks
@mmattel mmattel deleted the public-link-button branch October 20, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@mrow4a mrow4a Awaiting requested review from mrow4a

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@IljaN IljaN Awaiting requested review from IljaN

Assignees

@JammingBen JammingBen

Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @phil-davis @AlexAndBear