Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only][full-ci] Add api tests for listing files with propfind #38995

Merged
merged 5 commits into from
Jul 19, 2021

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Jul 14, 2021

Description

Add api tests for listing files with propfind

Related Issue

Motivation and Context

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiTrashbinRestore-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31181/89/1

@dpakach dpakach changed the title [Tests-Only] Add api tests for listing files with propfind [Tests-Only][full-ci] Add api tests for listing files with propfind Jul 15, 2021
@dpakach dpakach force-pushed the add-propfind-tests branch 6 times, most recently from 17a91c7 to ca18407 Compare July 16, 2021 05:40
@dpakach dpakach self-assigned this Jul 16, 2021
@phil-davis phil-davis force-pushed the add-propfind-tests branch from ca18407 to 88aeb4e Compare July 19, 2021 05:57
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had various mentions of "dav" and "DAV" in existing scenario descriptions and test steps. So I standardized that to say "DAV" when writing about it. "dav" is still used in URLs - that is part of the API!

I also adjust some words of test steps to more often talk about "resources" when the step is dealing with a possible mix of "files and folders". That is the "standard" term used for "files and folders". When we notice it, we should change to using "resource" or "resources" when the step is not specifically about "a/the folder" or "a/the file"

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 5a86cfe into master Jul 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the add-propfind-tests branch July 19, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tests-only] Add more test coverage for listing files with PROPFIND
3 participants