[Tests-only] Adds api tests for renaming received shares #38262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwikritiT
force-pushed
the
renameRecievedShare
branch
from
3928966 to
fcd75b5
Compare
swoichha
reviewed
Jan 1, 2021
Comment on lines
102
to
117
| Scenario: receiver renames a received share to different name on the same folder | ||
| Given user "Alice" has shared folder "PARENT" with user "Brian" | ||
| And user "Brian" has accepted share "/PARENT" offered by user "Alice" | ||
| When user "Brian" moves folder "/Shares/PARENT" to "/Shares/myFolder" using the WebDAV API | ||
| Then the HTTP status code should be "201" | ||
| And as "Brian" folder "/Shares/myFolder" should exist | ||
| But as "Alice" folder "myFolder" should not exist | ||
|
|
||
| Scenario: receiver renames a received file share to different name on the same folder | ||
| Given user "Alice" has shared file "textfile0.txt" with user "Brian" | ||
| And user "Brian" has accepted share "/textfile0.txt" offered by user "Alice" | ||
| When user "Brian" moves file "/Shares/textfile0.txt" to "/Shares/newFile.txt" using the WebDAV API | ||
| Then the HTTP status code should be "201" | ||
| And as "Brian" file "/Shares/newFile.txt" should exist | ||
| But as "Alice" file "newFile.txt" should not exist | ||
|
|
There was a problem hiding this comment.
You can make these two scenarios into a single scenario like here
core/tests/acceptance/features/apiFederationToShares2/federated.feature
Lines 192 to 193 in 83017e5
Comment on lines
118
to
146
| Scenario: receiver renames a received share to different name on the same folder for group sharing | ||
| Given group "grp1" has been created | ||
| And user "Brian" has been added to group "grp1" | ||
| And user "Alice" has shared folder "PARENT" with group "grp1" | ||
| And user "Brian" has accepted share "/PARENT" offered by user "Alice" | ||
| When user "Brian" moves folder "/Shares/PARENT" to "/Shares/myFolder" using the WebDAV API | ||
| Then the HTTP status code should be "201" | ||
| And as "Brian" folder "/Shares/myFolder" should exist | ||
| But as "Alice" folder "myFolder" should not exist | ||
|
|
||
| Scenario: receiver renames a received file share to different name on the same folder for group sharing | ||
| Given group "grp1" has been created | ||
| And user "Brian" has been added to group "grp1" | ||
| And user "Alice" has shared file "textfile0.txt" with group "grp1" | ||
| And user "Brian" has accepted share "/textfile0.txt" offered by user "Alice" | ||
| When user "Brian" moves file "/Shares/textfile0.txt" to "/Shares/newFile.txt" using the WebDAV API | ||
| Then the HTTP status code should be "201" | ||
| And as "Brian" file "/Shares/newFile.txt" should exist | ||
| But as "Alice" file "newFile.txt" should not exist |
| @@ -99,3 +99,115 @@ Feature: sharing | |||
| And as "Brian" file "/myFolder/renamedFile" should not exist | |||
| But as "Brian" file "/myFolder/fileInside" should exist | |||
|
|
|||
| Scenario: receiver renames a received share to different name on the same folder | |||
There was a problem hiding this comment.
Suggested change
| Scenario: receiver renames a received share to different name on the same folder | |
| Scenario: receiver renames a received folder share to a different name on the same folder |
| Then the HTTP status code should be "403" | ||
| And as "Brian" file "/myFolder/renamedFile" should not exist | ||
| But as "Brian" file "/myFolder/parent.txt" should exist | ||
| But as "Alice" file "/PARENT/parent.txt" should exist |
Comment on lines
174
to
186
| When user "Alice" shares folder "<sharer_folder>" with user "Brian" using the sharing API | ||
| And user "Brian" accepts share "/<sharer_folder>" offered by user "Alice" using the sharing API | ||
| And user "Brian" moves folder "/Shares/<sharer_folder>" to "/Shares/<receiver_folder>" using the WebDAV API | ||
| Then the HTTP status code should be "201" |
There was a problem hiding this comment.
should be Given steps? 🤔
| And as "Brian" folder "Shares/PARENT/new-folder" should exist | ||
| And as "Alice" folder "PARENT/new-folder" should exist | ||
| But as "Alice" folder "PARENT/CHILD" should not exist | ||
| When user "Brian" moves file "/Shares/PARENT/parent.txt" to "/Shares/PARENT/newFile.txt" using the WebDAV API |
There was a problem hiding this comment.
split scenarios for file and folder. in this case, if the move fails for the folder, the file move wouldn't get a chance to be checkded
SwikritiT
force-pushed
the
renameRecievedShare
branch
from
7e9b8a3 to
c5bdaa2
Compare
SwikritiT
force-pushed
the
renameRecievedShare
branch
from
c5bdaa2 to
1cc6b4c
Compare
Comment on lines
118
to
163
| Scenario: receiver renames a received share to different name on the same folder for group sharing | ||
| Given group "grp1" has been created | ||
| And user "Brian" has been added to group "grp1" | ||
| And user "Alice" has shared folder "PARENT" with group "grp1" | ||
| And user "Brian" has accepted share "/PARENT" offered by user "Alice" | ||
| And user "Alice" has shared file "textfile0.txt" with group "grp1" | ||
| And user "Brian" has accepted share "/textfile0.txt" offered by user "Alice" | ||
| When user "Brian" moves folder "/Shares/PARENT" to "/Shares/myFolder" using the WebDAV API | ||
| Then the HTTP status code should be "201" | ||
| And as "Brian" folder "/Shares/myFolder" should exist | ||
| But as "Alice" folder "myFolder" should not exist | ||
| When user "Brian" moves file "/Shares/textfile0.txt" to "/Shares/newFile.txt" using the WebDAV API | ||
| Then the HTTP status code should be "201" | ||
| And as "Brian" file "/Shares/newFile.txt" should exist | ||
| But as "Alice" file "newFile.txt" should not exist | ||
|
|
||
| Scenario: receiver renames a received share with share, read, change permissions in group sharing | ||
| Given group "grp1" has been created | ||
| And user "Brian" has been added to group "grp1" | ||
| And user "Alice" has shared folder "PARENT" with group "grp1" with permissions "share,read,change" | ||
| And user "Brian" has accepted share "/PARENT" offered by user "Alice" | ||
| When user "Brian" moves folder "/Shares/PARENT" to "myFolder" using the WebDAV API | ||
| Then the HTTP status code should be "201" | ||
| And as "Brian" folder "myFolder" should exist | ||
| But as "Alice" folder "myFolder" should not exist | ||
| When user "Brian" moves file "/myFolder/parent.txt" to "/myFolder/renamedFile" using the WebDAV API | ||
| Then the HTTP status code should be "201" | ||
| And as "Brian" file "/myFolder/renamedFile" should exist | ||
| And as "Alice" file "/PARENT/renamedFile" should exist | ||
| But as "Alice" file "/PARENT/parent.txt" should not exist | ||
|
|
||
| Scenario: receiver tries to rename a received share with share, read permissions in group sharing | ||
| Given group "grp1" has been created | ||
| And user "Brian" has been added to group "grp1" | ||
| And user "Alice" has shared folder "PARENT" with group "grp1" with permissions "share,read" | ||
| And user "Brian" has accepted share "/PARENT" offered by user "Alice" | ||
| When user "Brian" moves folder "/Shares/PARENT" to "/myFolder" using the WebDAV API | ||
| Then the HTTP status code should be "201" | ||
| And as "Brian" folder "myFolder" should exist | ||
| But as "Alice" folder "myFolder" should not exist | ||
| When user "Brian" moves file "/myFolder/parent.txt" to "/myFolder/renamedFile" using the WebDAV API | ||
| Then the HTTP status code should be "403" | ||
| And as "Brian" file "/myFolder/renamedFile" should not exist | ||
| And as "Brian" file "/myFolder/parent.txt" should exist | ||
| And as "Alice" file "/PARENT/parent.txt" should exist | ||
| But as "Alice" file "/PARENT/renamedFile" should not exist |
There was a problem hiding this comment.
these all scenarios should be separated for files and folders.
SwikritiT
force-pushed
the
renameRecievedShare
branch
from
1cc6b4c to
56a02f8
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
phil-davis
approved these changes
Jan 8, 2021
This was referenced Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for renaming received shares
Related Issue
How Has This Been Tested?
🤖
Screenshots (if appropriate):
Types of changes
Checklist: