Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Adds API tests to check the file deletion time #38239

Merged
merged 2 commits into from
Dec 23, 2020
Merged

[tests-only] Adds API tests to check the file deletion time #38239

merged 2 commits into from
Dec 23, 2020

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Dec 21, 2020

Co-authored-by: SwikritiT [email protected]

Description

checks if the files has appropriate deletion time in trashbin api response

Related Issue

How Has This Been Tested?

  • locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@CLAassistant
Copy link

CLAassistant commented Dec 21, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@saw-jan saw-jan requested a review from Talank December 23, 2020 08:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

dpakach
dpakach reviewed Dec 23, 2020
View reviewed changes
Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@phil-davis phil-davis merged commit 2d982b5 into owncloud:master Dec 23, 2020
@phil-davis phil-davis mentioned this pull request Dec 28, 2020
Closed
This was referenced Dec 30, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpakach dpakach dpakach left review comments

@phil-davis phil-davis phil-davis approved these changes

@jasson99 jasson99 Awaiting requested review from jasson99

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@swoichha swoichha Awaiting requested review from swoichha

@haribhandari07 haribhandari07 Awaiting requested review from haribhandari07

@Talank Talank Awaiting requested review from Talank

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@saw-jan @CLAassistant @phil-davis @dpakach @Talank @swoichha