Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Do not cleanup user data under-the-hood when testing on OCIS #38078

Closed
wants to merge 1 commit into from

Conversation

phil-davis
Copy link
Contributor

Description

OCIS PR owncloud/ocis#755 is implementing proper user cleanup when a user is deleted using the Provisioning API. When that is working, there will be no need for the acceptance test code to try to "manually" delete the shares and the user's files.

This branch do-not-cleanup-under-the-hood-on-ocis can be used for testing from OCIS. Do not merge this PR to core until there is a known-good implementation of OCIS PR owncloud/ocis#755

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor Author

phil-davis commented Jan 4, 2021

This is blocked by PR #755 which is blocked by cs3org/cs3apis#95

Update 2021-02-22: cs3org/cs3apis#95 was merged. Now there needs to be an implementation of "delete home" done in cs3org/reva and made available in owncloud/ocis

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor Author

Similar stuff to this has now happened in #38661 and more will be done - see issue owncloud/ocis#1985

@phil-davis phil-davis closed this Apr 29, 2021
@phil-davis phil-davis deleted the do-not-cleanup-under-the-hood-on-ocis branch April 29, 2021 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant