Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] test webdav locks when shares are received in a sub-folder #38052

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Oct 29, 2020

Description

extra tests to see if locking works correctly when shares are received in a sub-folder

P.S. no rush to update CI of ocis or reva for this, none of these tests are currently run on ocis

Related Issue

fixes owncloud/ocis#518
fixes #38006

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resharedSharesToRoot could have tag notToImplementOnOCIS

@@ -0,0 +1,71 @@
@api @smokeTest @public_link_share-feature-required @files_sharing-app-required @toImplementOnOCIS @issue-ocis-reva-172
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@api @smokeTest @public_link_share-feature-required @files_sharing-app-required @toImplementOnOCIS @issue-ocis-reva-172
@api @smokeTest @public_link_share-feature-required @files_sharing-app-required @notToImplementOnOCIS @issue-ocis-reva-172

Not a big deal - but these are test scenarios that "share to root" so they will always be not to implement on OCIS.

@@ -0,0 +1,157 @@
@api @toImplementOnOCIS @issue-ocis-reva-172 @files_sharing-app-required
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@api @toImplementOnOCIS @issue-ocis-reva-172 @files_sharing-app-required
@api @notToImplementOnOCIS @issue-ocis-reva-172 @files_sharing-app-required

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minor tag changes are not essential - approving.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 18dd1f4 into master Oct 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the webdavLocksSharingTestsToShare branch October 29, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tests-Only] Review and fix the tests that have sharing step to work with ocis enable sharing tests
2 participants