[tests-only] Improve skeleton upload error message

[phil-davis]

Description

1. When a test run uses the "upload" method to create skeleton files for a user and something goes wrong, all we get is a message:
   https://drone.owncloud.com/owncloud/ocis/1076/21/7

  Background:                                                                          # /srv/app/testrunner/tests/acceptance/features/apiShareManagementToShares/acceptSharesToSharesFolder.feature:7
    Given the administrator has set the default folder for received shares to "Shares" # OccContext::theAdministratorHasSetTheDefaultFolderForReceivedSharesTo()
    And parameter "shareapi_auto_accept_share" of app "core" has been set to "no"      # AppConfigurationContext::serverParameterHasBeenSetTo()
    And using OCS API version "1"                                                      # FeatureContext::usingOcsApiVersion()
    And using new DAV path                                                             # FeatureContext::usingOldOrNewDavPath()
    And these users have been created with default attributes and skeleton files:      # FeatureContext::theseUsersHaveBeenCreated()
      | username |
      | Alice    |
      | Brian    |
      Could not upload skeleton file (Exception)

"Could not upload skeleton file" is not so helpful. We do not even know which user it was.

Add information about the user, file, status to the exception message.

2. When a share could not be accepted, we get a message like Sharing::userHasReactedToShareOfferedBy could not accepted share to Brian by Alice

Fix it so it says "could not accept". Add the path of the share to the message, so it will be obvious exactly which share could not be accepted.

These were noticed while investigated test fails on OCIS.

How Has This Been Tested?

CI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[individual-it]

I still have to scroll right & left to review :-(

[phil-davis]

I still have to scroll right & left to review :-(

We will have to go-fund-me for a wide screen for you.

[individual-it]

That would be great, but would not solve the problem, you would need to make github change their UI

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information