Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Refactor etag tests #37980

Merged
merged 1 commit into from
Oct 6, 2020
Merged

[Tests-Only] Refactor etag tests #37980

merged 1 commit into from
Oct 6, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 5, 2020

Description

Add test steps for theseEtagsShouldNotHaveChanged and theseEtagsShouldHaveChanged to do checks of a table of etags and report a message about all the etags that do not pass the test.

Reduce the number of example scenarios in the etag tests by using the new steps to check for etag changes in multiple elements.

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #37980 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37980      +/-   ##
============================================
- Coverage     64.70%   64.70%   -0.01%     
  Complexity    19445    19445              
============================================
  Files          1286     1286              
  Lines         76032    76032              
  Branches       1336     1336              
============================================
- Hits          49196    49195       -1     
- Misses        26442    26443       +1     
  Partials        394      394              
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.87% <ø> (-0.01%) 19445.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
apps/files_external/lib/Lib/Storage/SFTP.php 56.52% <0.00%> (-0.49%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c7db53...0bfbb3e. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #37980 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37980   +/-   ##
=========================================
  Coverage     64.70%   64.70%           
  Complexity    19445    19445           
=========================================
  Files          1286     1286           
  Lines         76032    76032           
  Branches       1336     1336           
=========================================
  Hits          49196    49196           
  Misses        26442    26442           
  Partials        394      394           
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.87% <ø> (ø) 19445.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c7db53...d573ec8. Read the comment docs.

@phil-davis phil-davis force-pushed the refactor-etag-tests branch from 2b09927 to d573ec8 Compare October 5, 2020 16:26
@phil-davis phil-davis marked this pull request as ready for review October 5, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants