Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Refactored some oC10 bug demonstration scenarios in api test #37974

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

Talank
Copy link
Contributor

@Talank Talank commented Oct 3, 2020

Description

Refactored some API test scenarios demonstrating the actual behaviors. New scenarios demonstrating bugs in Oc10 are tagged skipOnOcV10 since these show the expected behavior and notToImplementOnOCIS because it only demonstrates an oC10 bug. Features files containing these new scenarios have been named with respect to the issue that it demonstrates.

Related Issue

How Has This Been Tested?

  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@Talank Talank changed the title Refactored some oC10 bug demonstration scenarios in api test [Tests-Only]Refactored some oC10 bug demonstration scenarios in api test Oct 3, 2020
@Talank Talank requested a review from phil-davis October 3, 2020 15:12
@Talank Talank self-assigned this Oct 3, 2020
@Talank Talank added the QA:team label Oct 3, 2020
@phil-davis
Copy link
Contributor

phil-davis commented Oct 5, 2020

I will rebase... - done.

@phil-davis phil-davis force-pushed the refactor-bug-demonstration branch 2 times, most recently from 1c20a02 to 26834f8 Compare October 5, 2020 10:25
@owncloud owncloud deleted a comment from update-docs bot Oct 5, 2020
@phil-davis phil-davis force-pushed the refactor-bug-demonstration branch from aaefb7f to 6cd69ac Compare October 6, 2020 03:12
@phil-davis
Copy link
Contributor

The scenarios need to be around the other way - the bug-demo scenario should be in the separate file, and the "good" scenario should be in the main feature file.

Some of the scenarios are tagged both skipOnOcV10 and notToImplementOnOCIS - so those will not run anywhere. The "good" scenario should be tagged skipOnOcV10 (because there is an oC10 issue, and the "good" scenario will not pass on oC10). The bug-demo scenario should be tagged notToImplementOnOCIS because we do not want to run it on OCIS - we do not want an OCIS developer to try and make it pass.

I am looking and refactoring - it should be just a matter of switching scenarios around, and adjusting the tags.

@phil-davis phil-davis force-pushed the refactor-bug-demonstration branch 2 times, most recently from 2f57133 to fe41b1d Compare October 6, 2020 06:17
@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #37974 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37974      +/-   ##
============================================
- Coverage     64.70%   64.70%   -0.01%     
  Complexity    19445    19445              
============================================
  Files          1286     1286              
  Lines         76032    76034       +2     
  Branches       1336     1336              
============================================
  Hits          49196    49196              
- Misses        26442    26444       +2     
  Partials        394      394              
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.87% <0.00%> (-0.01%) 19445.00 <1.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
core/Command/Upgrade.php 0.00% <0.00%> (ø) 29.00 <1.00> (ø)
core/ajax/update.php 0.00% <0.00%> (ø) 11.00 <0.00> (ø)
core/register_command.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
lib/private/Server.php 85.41% <0.00%> (+0.22%) 129.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d947b...f64ff1b. Read the comment docs.

@phil-davis phil-davis force-pushed the refactor-bug-demonstration branch from fe41b1d to f64ff1b Compare October 6, 2020 08:19
@phil-davis phil-davis merged commit c4e8297 into master Oct 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the refactor-bug-demonstration branch October 6, 2020 09:30
@phil-davis phil-davis changed the title [Tests-Only]Refactored some oC10 bug demonstration scenarios in api test [Tests-Only] Refactored some oC10 bug demonstration scenarios in api test Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants