Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] sharing related etag tests #37972

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Oct 2, 2020

Description

test is the etag is propagated correctly for shared folders

Related Issue

part of owncloud/product#144

Motivation and Context

mainly to make test etag propagation in OCIS

How Has This Been Tested?

🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #37972 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37972      +/-   ##
============================================
- Coverage     64.72%   64.70%   -0.02%     
  Complexity    19445    19445              
============================================
  Files          1286     1286              
  Lines         76036    76032       -4     
  Branches       1336     1336              
============================================
- Hits          49213    49196      -17     
- Misses        26429    26442      +13     
  Partials        394      394              
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.87% <0.00%> (-0.03%) 19445.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/templates/authenticate.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
core/templates/installation.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
core/templates/login.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
lib/private/Repair/DropOldTables.php 100.00% <ø> (ø) 6.00 <0.00> (ø)
settings/templates/panels/personal/profile.php 60.00% <0.00%> (ø) 0.00 <0.00> (ø)
settings/templates/setpassword.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
settings/templates/users/part.createuser.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
lib/private/Repair.php 75.26% <0.00%> (-6.46%) 21.00% <0.00%> (ø%)
core/Command/Maintenance/Repair.php 79.31% <0.00%> (-6.04%) 29.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b17c5...21e0b99. Read the comment docs.

@individual-it individual-it force-pushed the sharingEtagPropagationTest branch 2 times, most recently from c68932c to 489bebd Compare October 5, 2020 09:39
@individual-it individual-it self-assigned this Oct 5, 2020
@individual-it individual-it marked this pull request as ready for review October 5, 2020 09:44
@individual-it individual-it force-pushed the sharingEtagPropagationTest branch from ff5adb8 to 11e6da1 Compare October 5, 2020 10:09
@phil-davis phil-davis force-pushed the sharingEtagPropagationTest branch from ffad1c4 to 21e0b99 Compare October 5, 2020 12:18
@phil-davis phil-davis merged commit 370c1ee into master Oct 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the sharingEtagPropagationTest branch October 5, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants