New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Refactor apiShareCreateSpecial1 to use Shares folder #37938

Merged

phil-davis merged 3 commits into master from refactor-shareCreateSpecial1

Sep 28, 2020

Contributor

haribhandari07 commented Sep 23, 2020

Description

This PR makes apiShareCreateSpecial1 test scenarios to be valid in both oC10 and OCIS. OCIS always puts received shares into a folder called Shares for the share receiver. On OCIS, auto-accept shares is always disabled.

Related Issue

Part of enable sharing tests ocis#518

Motivation and Context

How Has This Been Tested?

CI

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)

Checklist:

haribhandari07 self-assigned this

haribhandari07 force-pushed the refactor-shareCreateSpecial1 branch from ae73e1a to d583627 Compare

September 24, 2020 03:03

haribhandari07 added 3 - To Review QA:team labels

haribhandari07 requested review from phil-davis and dpakach

September 24, 2020 03:29

codecov bot commented Sep 24, 2020 •

edited

Loading

Codecov Report

Merging #37938 into master will decrease coverage by 0.58%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #37938      +/-   ##
============================================
- Coverage     64.71%   64.13%   -0.59%     
  Complexity    19442    19442              
============================================
  Files          1286     1285       -1     
  Lines         76019    75978      -41     
  Branches       1336     1336              
============================================
- Hits          49196    48727     -469     
- Misses        26429    26857     +428     
  Partials        394      394

Flag	Coverage Δ	Complexity Δ
#javascript	`54.06% <ø> (ø)`	`0.00 <ø> (ø)`
#phpunit	`65.24% <ø> (-0.65%)`	`19442.00 <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
lib/private/DB/PostgreSqlMigrator.php	`0.00% <0.00%> (-100.00%)`	`4.00% <0.00%> (ø%)`
...ilder/ExpressionBuilder/PgSqlExpressionBuilder.php	`0.00% <0.00%> (-88.89%)`	`3.00% <0.00%> (ø%)`
lib/private/DB/AdapterOCI8.php	`0.00% <0.00%> (-86.67%)`	`4.00% <0.00%> (ø%)`
...ivate/Files/ObjectStore/HomeObjectStoreStorage.php	`0.00% <0.00%> (-86.67%)`	`8.00% <0.00%> (ø%)`
lib/private/DB/AdapterPgSql.php	`0.00% <0.00%> (-85.72%)`	`2.00% <0.00%> (ø%)`
...Builder/ExpressionBuilder/OCIExpressionBuilder.php	`0.00% <0.00%> (-85.19%)`	`18.00% <0.00%> (ø%)`
lib/private/DB/OracleMigrator.php	`0.00% <0.00%> (-76.85%)`	`10.00% <0.00%> (ø%)`
lib/private/DB/OracleConnection.php	`0.00% <0.00%> (-63.89%)`	`12.00% <0.00%> (ø%)`
lib/private/Files/Storage/Wrapper/Availability.php	`10.38% <0.00%> (-40.26%)`	`80.00% <0.00%> (ø%)`
lib/private/Autoloader.php	`73.17% <0.00%> (-19.52%)`	`20.00% <0.00%> (ø%)`
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1f272d...1724acc. Read the comment docs.

haribhandari07 force-pushed the refactor-shareCreateSpecial1 branch 2 times, most recently from 6393abe to bf3cf0d Compare

September 24, 2020 10:26

haribhandari07 mentioned this pull request

enable sharing tests owncloud/ocis#518

Closed

2 tasks

phil-davis requested changes

View reviewed changes

.../acceptance/features/apiShareCreateSpecialShares1/createShareWhenExcludedFromSharing.feature Show resolved Hide resolved

.../acceptance/features/apiShareCreateSpecialShares1/createShareWhenExcludedFromSharing.feature Show resolved Hide resolved

.../acceptance/features/apiShareCreateSpecialShares1/createShareWhenExcludedFromSharing.feature Show resolved Hide resolved

.../acceptance/features/apiShareCreateSpecialShares1/createShareWhenExcludedFromSharing.feature Show resolved Hide resolved

tests/acceptance/features/apiShareCreateSpecialShares1/createShareExpirationDate.feature Outdated Show resolved Hide resolved

tests/acceptance/features/apiShareCreateSpecialShares1/createShareExpirationDate.feature Outdated Show resolved Hide resolved

tests/acceptance/features/apiShareCreateSpecialShares1/createShareExpirationDate.feature Show resolved Hide resolved

tests/acceptance/features/apiShareCreateSpecialShares1/createShareExpirationDate.feature Show resolved Hide resolved

tests/acceptance/features/apiShareCreateSpecialShares1/createShareExpirationDate.feature Show resolved Hide resolved

tests/acceptance/features/apiShareCreateSpecialShares1/createShareExpirationDate.feature Show resolved Hide resolved

Contributor

phil-davis commented Sep 25, 2020

I also raised issue #37944 - it applies to a lot of these "sharing to share_folder" scenarios in multiple PRs. So we can sort that out next week.


          [Tests-Only] Refactor apiShareCreateSpecial1 to use Shares folder

bdeae2c

dpakach previously requested changes

View reviewed changes

Contributor

dpakach left a comment •

edited

Loading

Some scenarios have
Then the status code should be <code> step which checks the status of accepting the share not creating the share.
I have not commented on all of them. Please go through all the scenarios fix those to check the status of Sharing step.

tests/acceptance/features/apiShareCreateSpecialShares1/createShareExpirationDate.feature Show resolved Hide resolved

tests/acceptance/features/apiShareCreateSpecialShares1/createShareExpirationDate.feature

Comment on lines +39 to +71

		Then the OCS status code should be "<ocs_status_code>"
		And the HTTP status code should be "<http_status_code>"

Contributor

dpakach Sep 28, 2020

This step is supposed to check the status code of sharing step but here it checks the status of accepting the share.

tests/acceptance/features/apiShareCreateSpecialShares1/createShareExpirationDate.feature Show resolved Hide resolved

tests/acceptance/features/apiShareCreateSpecialShares1/createShareExpirationDate.feature

Comment on lines +143 to +206

		Then the OCS status code should be "<ocs_status_code>"
		And the HTTP status code should be "<http_status_code>"

Contributor

dpakach Sep 28, 2020

This step is supposed to check the status code of sharing step but here it checks the status of accepting the share.

...s/acceptance/features/apiShareCreateSpecialShares1/createShareReceivedInMultipleWays.feature

		Then the OCS status code should be "<ocs_status_code>"
		And the HTTP status code should be "200"

Contributor

dpakach Sep 28, 2020

This step is supposed to check the status code of sharing step but here it checks the status of accepting the share.

...s/acceptance/features/apiShareCreateSpecialShares1/createShareReceivedInMultipleWays.feature

		Then the OCS status code should be "<ocs_status_code>"
		And the HTTP status code should be "200"

Contributor

dpakach Sep 28, 2020

This step is supposed to check the status code of sharing step but here it checks the status of accepting the share.


          [Tests-Only] Add tests and tag for issue-37883 and also fix status co…

ab80ea6

…de check in features

haribhandari07 force-pushed the refactor-shareCreateSpecial1 branch from bf3cf0d to ab80ea6 Compare

September 28, 2020 05:08

haribhandari07 requested review from dpakach and phil-davis

September 28, 2020 05:12

phil-davis approved these changes

View reviewed changes

phil-davis added 4 - To release and removed 3 - To Review labels


          Standardize apiShare test suite names

1724acc

phil-davis dismissed dpakach’s stale review

September 28, 2020 06:38

changes done

phil-davis merged commit c76cec3 into master

delete-merged-branch bot deleted the refactor-shareCreateSpecial1 branch

September 28, 2020 06:44

This was referenced Sep 28, 2020

[Tests-Only] Fixup API sharing test suite names #37955

Merged

[Tests-Only] Bump core test commit id as at 20201006 owncloud/ocis#645

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 - To release QA:team