Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] refactor shareManagement test suite for Shares subfolder and root #37936

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Sep 23, 2020

Description

Split apiShareManagement test suite to 2 different test suites, one that uses the share folder and one in which shares are received in the root.

Related Issue

Motivation and Context

Receiving shares in the root folder is not available in ocis so this needs to be done so we can run the sharing tests in ocis.

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@dpakach
Copy link
Contributor Author

dpakach commented Sep 23, 2020

@phil-davis This suite already had a lot of tests checking with receive share folder and auto accept shares. I have removed a lot of scenarios in the apiShareManagementToShares suite as I thought those would not be relevant running with OCIS. Please review.

@dpakach dpakach mentioned this pull request Sep 23, 2020
2 tasks
@dpakach dpakach force-pushed the refactor-share-management branch 2 times, most recently from 1628a1c to 20419de Compare September 24, 2020 03:32
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #37936 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37936      +/-   ##
============================================
- Coverage     64.71%   64.71%   -0.01%     
  Complexity    19442    19442              
============================================
  Files          1286     1286              
  Lines         76020    76022       +2     
  Branches       1336     1336              
============================================
  Hits          49196    49196              
- Misses        26430    26432       +2     
  Partials        394      394              
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.88% <ø> (-0.01%) 19442.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
lib/private/NavigationManager.php 78.57% <0.00%> (-1.92%) 30.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f049399...20419de. Read the comment docs.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many of the review comments are notes, or just questions.

Comment on lines +449 to +445
And user "David" should not see the following elements
| /PARENT%20(2)/ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's tricky to work out what elements to test that David should not see.
But in this case it seems like a good idea - when David accepts the share, his skeleton will get initialized in the code running for that "accept share" API call. A personal /PARENT folder will become visible for David. So we double-check that PARENT (2) did not somehow accidentally appear.

@phil-davis
Copy link
Contributor

I will rebase - other suite names changed since this PR was submitted.

@phil-davis phil-davis force-pushed the refactor-share-management branch from 7df16d4 to 86abadd Compare September 24, 2020 08:46
@phil-davis
Copy link
Contributor

Rebase done - can be merged when drone CI passes.

@phil-davis phil-davis force-pushed the refactor-share-management branch from 86abadd to 37918a5 Compare September 24, 2020 08:48
@phil-davis phil-davis force-pushed the refactor-share-management branch from 37918a5 to 6b5e3f1 Compare September 24, 2020 08:55
@phil-davis phil-davis merged commit 0ca68a6 into master Sep 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the refactor-share-management branch September 24, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants