-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests-Only] refactor shareManagement test suite for Shares subfolder and root #37936
Conversation
@phil-davis This suite already had a lot of tests checking with receive share folder and auto accept shares. I have removed a lot of scenarios in the |
1628a1c
to
20419de
Compare
tests/acceptance/features/apiShareManagementToShares/moveReceivedShare.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiShareManagementToShares/moveReceivedShare.feature
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #37936 +/- ##
============================================
- Coverage 64.71% 64.71% -0.01%
Complexity 19442 19442
============================================
Files 1286 1286
Lines 76020 76022 +2
Branches 1336 1336
============================================
Hits 49196 49196
- Misses 26430 26432 +2
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of the review comments are notes, or just questions.
tests/acceptance/features/apiShareManagementToShares/acceptShares.feature
Show resolved
Hide resolved
tests/acceptance/features/apiShareManagementToShares/acceptShares.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiShareManagementToShares/acceptShares.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiShareManagementToShares/acceptShares.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiShareManagementToShares/acceptShares.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiShareManagementToShares/acceptShares.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiShareManagementToShares/acceptShares.feature
Outdated
Show resolved
Hide resolved
And user "David" should not see the following elements | ||
| /PARENT%20(2)/ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's tricky to work out what elements to test that David should not see.
But in this case it seems like a good idea - when David accepts the share, his skeleton will get initialized in the code running for that "accept share" API call. A personal /PARENT
folder will become visible for David. So we double-check that PARENT (2)
did not somehow accidentally appear.
tests/acceptance/features/apiShareManagementToShares/acceptShares.feature
Show resolved
Hide resolved
I will rebase - other suite names changed since this PR was submitted. |
7df16d4
to
86abadd
Compare
Rebase done - can be merged when drone CI passes. |
86abadd
to
37918a5
Compare
37918a5
to
6b5e3f1
Compare
Description
Split
apiShareManagement
test suite to 2 different test suites, one that uses the share folder and one in which shares are received in the root.Related Issue
Motivation and Context
Receiving shares in the root folder is not available in ocis so this needs to be done so we can run the sharing tests in ocis.
How Has This Been Tested?
🤖
Screenshots (if appropriate):
Types of changes
Checklist: