[Tests-Only] Refactor apiShareCreateSpecial2 to use Shares folder #37929
Conversation
haribhandari07
force-pushed
the
refactor-shareCreateSpecial2
branch
from
f494688 to
243fc57
Compare
| Scenario Outline: Do not allow sharing of the entire share_folder | ||
| Given using OCS API version "<ocs_api_version>" | ||
| And user "Brian" has been created with default attributes and without skeleton files | ||
| And the administrator has set the default folder for received shares to "<share_folder>" |
There was a problem hiding this comment.
@phil-davis for this kind of case, do we need to run the scenario in ocis? If we are running, what will be the default folder for received share, /Shares/<share_folder> ?
There was a problem hiding this comment.
This scenario can be deleted from here. Keep it in apiShareCreateSpecialShares2 suite.
In there, it needs to use share_folder /Shares (which is the usual value for the tests) and check to see what happens when Brian tries to share /Shares - that will be a valid test in both oC10 and OCIS.
Codecov Report
@@ Coverage Diff @@
## master #37929 +/- ##
=========================================
Coverage 64.71% 64.71%
Complexity 19442 19442
=========================================
Files 1286 1286
Lines 76022 76022
Branches 1336 1336
=========================================
Hits 49196 49196
Misses 26432 26432
Partials 394 394
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| Scenario Outline: Do not allow sharing of the entire share_folder | ||
| Given using OCS API version "<ocs_api_version>" | ||
| And user "Brian" has been created with default attributes and without skeleton files | ||
| And the administrator has set the default folder for received shares to "<share_folder>" |
There was a problem hiding this comment.
This scenario can be deleted from here. Keep it in apiShareCreateSpecialShares2 suite.
In there, it needs to use share_folder /Shares (which is the usual value for the tests) and check to see what happens when Brian tries to share /Shares - that will be a valid test in both oC10 and OCIS.
...acceptance/features/apiShareCreateSpecialShares2/createShareGroupAndUserWithSameName.feature
Show resolved
Hide resolved
haribhandari07
force-pushed
the
refactor-shareCreateSpecial2
branch
from
243fc57 to
5befe03
Compare
|
Looks good - can be merged when drone CI passes. |
Description
This PR makes
apiShareCreateSpecial2test scenarios to be valid in both oC10 and OCIS. OCIS always puts received shares into a folder called Shares for the share receiver. On OCIS, auto-accept shares is always disabled.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: