Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Skip favorites capability scenario on 10.5.0 #37781

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 6, 2020

Description

  1. The favorites capability was added in PR Add explicit favorite capability entry #37673 but unfortunately that did not get into 10.5.0 release.

Adjust the test scenarios so that this new capability is not checked on a 10.5.0 system.

  1. Run federation tests with a federated server running 10.4.1 (rather than 10.3.2).

Note: federation tests also run against daily-master-qa and latest. latest is now 10.5.0.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #37781 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37781   +/-   ##
=========================================
  Coverage     64.71%   64.71%           
  Complexity    19391    19391           
=========================================
  Files          1284     1284           
  Lines         75753    75753           
  Branches       1333     1333           
=========================================
  Hits          49021    49021           
  Misses        26340    26340           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.88% <ø> (ø) 19391.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5a25fa...6b9715d. Read the comment docs.

@phil-davis phil-davis force-pushed the skip-favorites-capability-on-10.5.0 branch from 6b9715d to 3643c22 Compare August 6, 2020 08:17
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #37781 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37781   +/-   ##
=========================================
  Coverage     64.71%   64.71%           
  Complexity    19391    19391           
=========================================
  Files          1284     1284           
  Lines         75753    75753           
  Branches       1333     1333           
=========================================
  Hits          49021    49021           
  Misses        26340    26340           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.88% <ø> (ø) 19391.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5a25fa...3643c22. Read the comment docs.

@phil-davis phil-davis merged commit a2584bb into master Aug 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the skip-favorites-capability-on-10.5.0 branch August 6, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants