Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] remove unneded tag in tests #37329

Merged
merged 1 commit into from
May 4, 2020
Merged

Conversation

individual-it
Copy link
Member

Description

This test does not work in ocis because of the web-style session, there is no such thing in ocis, other tests that contain this step are skipped with no issue tag

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@individual-it individual-it requested a review from PVince81 May 4, 2020 06:27
@individual-it individual-it self-assigned this May 4, 2020
@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #37329 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37329   +/-   ##
=========================================
  Coverage     64.53%   64.53%           
  Complexity    19167    19167           
=========================================
  Files          1266     1266           
  Lines         74957    74957           
  Branches       1331     1331           
=========================================
  Hits          48373    48373           
  Misses        26192    26192           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.69% <ø> (ø) 19167.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a256d11...bf37b76. Read the comment docs.

@phil-davis phil-davis merged commit 00e46dc into master May 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the removeTagInTest branch May 4, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants