Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix for app:enable in case of not valid/not existing enterpri… #36947

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Feb 12, 2020

Description

Revert #36399

Reason

  • CI could not enable apps from the CLI
testing cannot be enabled because of invalid enterprise key```
- The enterprise check for a license key is disabled in CI
- This check on the cli command breaks the current behavior

## Further Reasoning
- In the future, this function will be not needed anymore

@update-docs
Copy link

update-docs bot commented Feb 12, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #36947 into release-10.4.0 will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.4.0   #36947      +/-   ##
====================================================
+ Coverage             64.39%   64.67%   +0.27%     
+ Complexity            19135    19132       -3     
====================================================
  Files                  1270     1270              
  Lines                 74872    74901      +29     
  Branches               1329     1329              
====================================================
+ Hits                  48214    48440     +226     
+ Misses                26267    26070     -197     
  Partials                391      391              
Flag Coverage Δ Complexity Δ
#javascript 54.17% <ø> (ø) 0.00 <ø> (ø) ⬆️
#phpunit 65.84% <50.00%> (+0.30%) 19132.00 <1.00> (-3.00) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/Command/Scan.php 71.92% <0.00%> (-9.75%) 61.00% <0.00%> (ø%)
lib/private/Files/Cache/HomePropagator.php 77.77% <0.00%> (-9.73%) 3.00% <0.00%> (ø%)
lib/private/DB/Connection.php 66.91% <0.00%> (-0.74%) 49.00% <0.00%> (ø%)
lib/private/Files/View.php 84.54% <0.00%> (-0.30%) 389.00% <0.00%> (ø%)
apps/dav/lib/Connector/Sabre/File.php 84.19% <0.00%> (+0.64%) 115.00% <0.00%> (ø%) ⬆️
lib/private/Share/Share.php 71.15% <0.00%> (+2.20%) 501.00% <0.00%> (ø%) ⬆️
apps/files_versions/lib/Storage.php 72.39% <0.00%> (+2.53%) 95.00% <0.00%> (ø%) ⬆️
lib/private/legacy/util.php 72.57% <0.00%> (+2.55%) 219.00% <0.00%> (ø%) ⬆️
lib/private/Files/Storage/Common.php 85.01% <0.00%> (+3.36%) 138.00% <0.00%> (ø%) ⬆️
lib/private/Files/Type/Detection.php 74.56% <0.00%> (+4.38%) 52.00% <0.00%> (ø%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84e3fa...db951a9. Read the comment docs.

@phil-davis
Copy link
Contributor

@micbar can we write some words about why this needs to be reverted - then if someone looks at it again for a future release they will have some idea what the problem is.

@micbar
Copy link
Contributor Author

micbar commented Feb 13, 2020

@phil-davis

@micbar micbar merged commit f1a20a0 into release-10.4.0 Feb 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the revert36399 branch February 14, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants