Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Bug reproduce 36920 #36941

Merged
merged 1 commit into from
Feb 14, 2020
Merged

[Tests-Only] Bug reproduce 36920 #36941

merged 1 commit into from
Feb 14, 2020

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Feb 11, 2020 •
edited
Loading

Description

Issue stated inside #36920 is added as acceptance test scenario

Related Issue

Motivation and Context

track existing bug!

How Has This Been Tested?

  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review February 12, 2020 11:12
@mmattel mmattel requested a review from phil-davis February 12, 2020 11:20
@mmattel
Copy link
Contributor

mmattel commented Feb 12, 2020

Adding @phil-davis as he was in #36821

@kiranparajuli589 kiranparajuli589 self-assigned this Feb 12, 2020
@owncloud owncloud deleted a comment from codecov bot Feb 13, 2020
@kiranparajuli589 kiranparajuli589 mentioned this pull request Feb 13, 2020
Closed
@phil-davis phil-davis changed the title Bug reproduce 36920 [Tests-Only] Bug reproduce 36920 Feb 13, 2020
@owncloud owncloud deleted a comment from update-docs bot Feb 13, 2020
phil-davis
phil-davis approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed a few words in the step text (putting in the and so on).
The code looks good.

@phil-davis phil-davis mentioned this pull request Feb 13, 2020
Closed
@owncloud owncloud deleted a comment from codecov bot Feb 14, 2020
@mmattel
Copy link
Contributor

mmattel commented Feb 14, 2020

@kiranparajuli589 pls run make test-php-style-fix to fix the complains from CI regarding code style

@owncloud owncloud deleted a comment from codecov bot Feb 14, 2020
@owncloud owncloud deleted a comment from codecov bot Feb 14, 2020
@phil-davis
Copy link
Contributor

I will override the silly codecov result when I get my laptop out...

@phil-davis phil-davis merged commit 099f313 into master Feb 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the bug-reproduce-36920 branch February 14, 2020 15:13
@owncloud owncloud deleted a comment from codecov bot Feb 14, 2020
@kiranparajuli589 kiranparajuli589 mentioned this pull request Feb 28, 2020
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@kiranparajuli589 kiranparajuli589

Labels
4 - To release bug-analysis dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiranparajuli589 @mmattel @phil-davis