Implement coding-standard 2.0.0

[phil-davis]

Description

owncloud/coding-standard 2.0.0 adds fixers for things that are deprecated and being removed in future releases of phpunit - see owncloud/coding-standard#20 and a core PR that recently applied these refactorings #36501 for details.

Implement this in core CI so it will now be enforced.

Do make test-php-style-fix to refactor recent additions of @expectedException annotations.

Developers, whose unit test code now fails code style checks, can simply make test-php-style-fix to automatically apply the fixes.

Also see https://thephp.cc/news/2016/02/questioning-phpunit-best-practices for information/reasoning.

Motivation and Context

Be ready when we need to move forward to phpunit8.

How Has This Been Tested?

make test-php-style-fix

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[codecov]

Codecov Report

Merging #36580 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #36580   +/-   ##
=========================================
  Coverage     64.66%   64.66%           
  Complexity    19049    19049           
=========================================
  Files          1269     1269           
  Lines         74498    74498           
  Branches       1311     1311           
=========================================
  Hits          48171    48171           
  Misses        25941    25941           
  Partials        386      386

Flag	Coverage Δ	Complexity Δ
#javascript	54.02% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.83% <ø> (ø)	19049 <ø> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf40428...93eb7f5. Read the comment docs.

[codecov]

Codecov Report

Merging #36580 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #36580   +/-   ##
=========================================
  Coverage     64.66%   64.66%           
  Complexity    19049    19049           
=========================================
  Files          1269     1269           
  Lines         74498    74498           
  Branches       1311     1311           
=========================================
  Hits          48171    48171           
  Misses        25941    25941           
  Partials        386      386

Flag	Coverage Δ	Complexity Δ
#javascript	54.02% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.83% <ø> (ø)	19049 <ø> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf40428...93eb7f5. Read the comment docs.