Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for checking expiry date enforcement while resharing #36567

Merged

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Dec 11, 2019

Description

Add more api acceptance tests for checking expiry date enforcement while resharing.

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Copy link
Member

@skshetry skshetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😉

@skshetry skshetry requested a review from phil-davis December 11, 2019 04:33
@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #36567 into feature/user_group_share_expiration will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                            Coverage Diff                            @@
##             feature/user_group_share_expiration   #36567      +/-   ##
=========================================================================
- Coverage                                  64.64%   64.64%   -0.01%     
  Complexity                                 19078    19078              
=========================================================================
  Files                                       1269     1269              
  Lines                                      74668    74667       -1     
  Branches                                    1322     1322              
=========================================================================
- Hits                                       48269    48268       -1     
  Misses                                     26007    26007              
  Partials                                     392      392
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.82% <ø> (-0.01%) 19078 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/Archive/TAR.php 87.23% <0%> (-0.09%) 56% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e219d48...203e007. Read the comment docs.

@skshetry skshetry merged commit 17d3281 into feature/user_group_share_expiration Dec 11, 2019
@skshetry skshetry deleted the api-reshare-expiration branch December 11, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants