Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin sabre/http #36495

Merged
merged 1 commit into from
Nov 30, 2019
Merged

unpin sabre/http #36495

merged 1 commit into from
Nov 30, 2019

Conversation

phil-davis
Copy link
Contributor

Description

After #36490 sabre/http is in good shape. It got pinned to a particular version for the last week. Now we can unpin it so that when we do composer update that composer will find new releases for us.

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #36495 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36495   +/-   ##
=========================================
  Coverage     64.68%   64.68%           
  Complexity    19023    19023           
=========================================
  Files          1268     1268           
  Lines         74362    74362           
  Branches       1309     1309           
=========================================
  Hits          48100    48100           
  Misses        25876    25876           
  Partials        386      386
Flag Coverage Δ Complexity Δ
#javascript 54% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.86% <ø> (ø) 19023 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9e2677...13d52d2. Read the comment docs.

@individual-it individual-it merged commit 69008d2 into master Nov 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the unpin-sabre-http branch November 30, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants