Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[For 10.4] Support Oracle connect string #36489

Merged
merged 2 commits into from
Dec 3, 2019
Merged

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Nov 28, 2019

backport #35413

Description

Some failover/HA configurations in the Oracle world require support of connect strings.
Examples can be found here: https://docs.oracle.com/database/121/HABPT/config_fcf.htm#HABPT5391

This PR adds installation and operations using a new database config parameter: dbconnectionstring in config.php

Motivation and Context

Support Oracle HA/Failover scenarios

How Has This Been Tested?

  • basic connectivity is done manually and using drone
  • real fail over scenario is to be tested manually as well

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #36489 into master will increase coverage by <.01%.
The diff coverage is 31.03%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #36489      +/-   ##
============================================
+ Coverage     64.68%   64.68%   +<.01%     
- Complexity    19023    19024       +1     
============================================
  Files          1268     1268              
  Lines         74362    74367       +5     
  Branches       1309     1309              
============================================
+ Hits          48100    48104       +4     
- Misses        25876    25877       +1     
  Partials        386      386
Flag Coverage Δ Complexity Δ
#javascript 54% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.86% <31.03%> (ø) 19024 <0> (+1) ⬆️
Impacted Files Coverage Δ Complexity Δ
core/Command/Maintenance/Install.php 0% <0%> (ø) 21 <0> (+1) ⬆️
lib/private/Setup/AbstractDatabase.php 0% <0%> (ø) 12 <0> (ø) ⬇️
lib/private/Setup/OCI.php 0% <0%> (ø) 35 <0> (-1) ⬇️
lib/private/DB/ConnectionFactory.php 90.41% <100%> (+0.55%) 22 <0> (+2) ⬆️
lib/private/DB/MDB2SchemaReader.php 96.11% <100%> (ø) 76 <0> (-1) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16b6aee...e9e1443. Read the comment docs.

@micbar micbar changed the title Feature/oracle failover [For 10.4] Feature/oracle failover Nov 29, 2019
@micbar micbar added this to the development milestone Nov 29, 2019
@mmattel
Copy link
Contributor

mmattel commented Nov 29, 2019

@DeepDiver1975 @settermjd needs documentation?

@phil-davis
Copy link
Contributor

Existing CI demonstrates at least that ordinary Oracle database install has not been broken ;)
Then see comment #35413 (comment)
How to do something manually to test with an Oracle HA/failover configuration?

@DeepDiver1975
Copy link
Member Author

It is not the reaponsibility of our testing setup to test oracles failover capabilities. I so assume this works 🤗

This pr allows the necessary setups of the Database connection in owncloud.

@DeepDiver1975 DeepDiver1975 changed the title [For 10.4] Feature/oracle failover [For 10.4] Support Oracle connect string Dec 2, 2019
@DeepDiver1975 DeepDiver1975 force-pushed the feature/oracle-failover branch from 71ff27e to e9e1443 Compare December 2, 2019 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants