[For 10.4] user is only allowed to see their own home trashbin #36488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karakayasemi
force-pushed
the
acl-trashbin-api
branch
from
83541d1 to
4ea0c2b
Compare
Codecov Report
@@ Coverage Diff @@
## master #36488 +/- ##
============================================
+ Coverage 64.68% 64.68% +<.01%
- Complexity 19023 19026 +3
============================================
Files 1268 1268
Lines 74362 74371 +9
Branches 1309 1309
============================================
+ Hits 48100 48106 +6
- Misses 25876 25879 +3
Partials 386 386
Continue to review full report at Codecov.
|
karakayasemi
force-pushed
the
acl-trashbin-api
branch
5 times, most recently
from
8f37218 to
b2c08a9
Compare
phil-davis
reviewed
Nov 30, 2019
phil-davis
changed the title
phil-davis
changed the title
karakayasemi
force-pushed
the
acl-trashbin-api
branch
from
b2c08a9 to
d7710af
Compare
|
@micbar this needs a developer technical review of the code, then IMO it can be merged for 10.4 release. |
DeepDiver1975
requested changes
Dec 2, 2019
| list(, $name) = \Sabre\Uri\split($principalInfo['uri']); | ||
| $sessionUser = \OC::$server->getUserSession()->getUser(); | ||
| if ($sessionUser === null || $name !== $sessionUser->getUID()) { | ||
| throw new NotAuthenticated(); |
There was a problem hiding this comment.
shall we log something here?
There was a problem hiding this comment.
I looked at similar classes, generally, we do not log anything in RootCollections, I could not find specific things to log. If you have any suggestions, I can add it.
karakayasemi
force-pushed
the
acl-trashbin-api
branch
from
d7710af to
1bffb58
Compare
|
@DeepDiver1975 or somebody - review again, and we can merge? |
DeepDiver1975
approved these changes
Dec 6, 2019
11 tasks
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User is only allowed to see their own home trashbin.
Related Issue
Motivation and Context
Trashbin API had allowed users to see the trashbin content of other users. This bug has been resolved.
How Has This Been Tested?
Followed #36378's reproduce steps. Also, acceptance tests already cover this issue.
Types of changes
Checklist: