Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap library to 3.4.1 #36344

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Conversation

jvillafanez
Copy link
Member

@jvillafanez jvillafanez commented Oct 28, 2019

Description

Update library to 3.4.1

Related Issue

https://github.com/owncloud/enterprise/issues/3588

Motivation and Context

How Has This Been Tested?

No special tests other than clicking around. It's unclear where the library is used. The core.json file points to "bootstrap/js/tooltip.js" so I've checked around tooltips: no problems found with this.
Other than that, basic ownCloud functionality works without apparent problems.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #36344 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36344   +/-   ##
=========================================
  Coverage     64.86%   64.86%           
  Complexity    19775    19775           
=========================================
  Files          1271     1271           
  Lines         74707    74707           
  Branches       1309     1309           
=========================================
  Hits          48455    48455           
  Misses        25866    25866           
  Partials        386      386
Flag Coverage Δ Complexity Δ
#javascript 54% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.05% <ø> (ø) 19775 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 295d62a...e847148. Read the comment docs.

@DeepDiver1975 DeepDiver1975 merged commit ad6043f into master Nov 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the bootstrap_update_341 branch November 5, 2019 09:30
@davitol davitol mentioned this pull request Nov 26, 2019
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants