Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New changelog item #36342

Merged
merged 1 commit into from
Oct 29, 2019
Merged

New changelog item #36342

merged 1 commit into from
Oct 29, 2019

Conversation

jvillafanez
Copy link
Member

Description

New changelog item

Related Issue

Linking to #36242

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the time.

@@ -0,0 +1,6 @@
Bugfix: Fix SMB access denied error while listing the contents of the folder

This can happen in a DFSr folder, where such folder is visible even though the user doesn't have permissions to read the folder.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The long description needs to be in past tense.

@jvillafanez jvillafanez force-pushed the changelog_smb_access_denied branch from d507e73 to cb4013a Compare October 28, 2019 08:04
@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #36342 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36342   +/-   ##
=========================================
  Coverage     64.86%   64.86%           
  Complexity    19775    19775           
=========================================
  Files          1271     1271           
  Lines         74707    74707           
  Branches       1309     1309           
=========================================
  Hits          48455    48455           
  Misses        25866    25866           
  Partials        386      386
Flag Coverage Δ Complexity Δ
#javascript 54% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.05% <ø> (ø) 19775 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 295d62a...3425680. Read the comment docs.

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

changelog/unreleased/36242 Outdated Show resolved Hide resolved
@jvillafanez jvillafanez force-pushed the changelog_smb_access_denied branch from cb4013a to 3425680 Compare October 29, 2019 07:59
@micbar micbar merged commit 78bdb1c into master Oct 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the changelog_smb_access_denied branch October 29, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants