Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show progressbar if option --progress is set #36304

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Oct 21, 2019

Description

Related Issue

How Has This Been Tested?

  • occ system:cron -> no output
  • occ system:cron -p -> see progress bar

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #36304 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #36304      +/-   ##
============================================
+ Coverage        65%      65%   +<.01%     
- Complexity    19773    19775       +2     
============================================
  Files          1271     1271              
  Lines         74696    74701       +5     
  Branches       1309     1309              
============================================
+ Hits          48555    48560       +5     
  Misses        25755    25755              
  Partials        386      386
Flag Coverage Δ Complexity Δ
#javascript 54% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.21% <100%> (ø) 19775 <0> (+2) ⬆️
Impacted Files Coverage Δ Complexity Δ
core/Command/System/Cron.php 88.46% <100%> (+1.22%) 14 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c75fecf...ad3e731. Read the comment docs.

Copy link

@Faldrian Faldrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tried it in my 10.3 install, it works as expected.

@DeepDiver1975 DeepDiver1975 requested a review from micbar October 22, 2019 06:09
@DeepDiver1975 DeepDiver1975 merged commit 822f3e6 into master Oct 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/36298 branch October 22, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New system:cron is generating output when everything is fine
4 participants