[stable10] use a multi line approach to display share autocomplete #35397

DeepDiver1975 · 2019-05-31T15:23:34Z

Description

Related Issue

Fixes 10.2 RC1 Share with "federation" text is cut off #35098

How Has This Been Tested?

✋

Screenshots (if appropriate):

Federated or Guest

Group

With additional user information

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

Backport (if applicable set "backport-request" label and remove when the backport was done)

pmaier1

This is so beautiful ❤️

micbar · 2019-06-02T19:42:56Z

@DeepDiver1975 Seems like the WebUI Sharing tests have on failing Scenario

phil-davis · 2019-06-03T04:44:57Z

With this PR the webUI has a separate UI element that displays the type of the potential share recipient. e.g. "User", "Group", "Federated". Previously this information was just appended in text after the display name "(group)", "(federated)".

The webUI tests need enhancing so that they process this extra UI element when working out which share recipient to click on in the dropdown list, and when checking if the correct matching entries are found in the dropdown list.

I will look.

codecov · 2019-06-03T06:50:44Z

Codecov Report

Merging #35397 into stable10 will decrease coverage by 0.02%.
The diff coverage is 57.14%.

@@              Coverage Diff               @@
##             stable10   #35397      +/-   ##
==============================================
- Coverage       64.68%   64.65%   -0.03%     
  Complexity      20103    20103              
==============================================
  Files            1293     1293              
  Lines           76976    76977       +1     
  Branches         1300     1301       +1     
==============================================
- Hits            49793    49771      -22     
- Misses          26799    26821      +22     
- Partials          384      385       +1

Flag	Coverage Δ	Complexity Δ
#javascript	`53.84% <57.14%> (-0.01%)`	`0 <0> (ø)`
#phpunit	`65.8% <ø> (-0.04%)`	`20103 <ø> (ø)`

Impacted Files	Coverage Δ	Complexity Δ
core/js/sharedialogview.js	`78.1% <57.14%> (-0.68%)`	`0 <0> (ø)`
apps/files_sharing/lib/External/Manager.php	`77.38% <0%> (-12.62%)`	`32% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e301daf...f11dd61. Read the comment docs.

codecov · 2019-06-03T06:50:45Z

Codecov Report

Merging #35397 into stable10 will increase coverage by <.01%.
The diff coverage is 57.14%.

@@              Coverage Diff               @@
##             stable10   #35397      +/-   ##
==============================================
+ Coverage        64.8%    64.8%   +<.01%     
  Complexity      20183    20183              
==============================================
  Files            1293     1293              
  Lines           77170    77173       +3     
  Branches         1300     1301       +1     
==============================================
+ Hits            50010    50012       +2     
  Misses          26776    26776              
- Partials          384      385       +1

Flag	Coverage Δ	Complexity Δ
#javascript	`53.85% <57.14%> (ø)`	`0 <0> (ø)`	⬇️
#phpunit	`65.96% <ø> (ø)`	`20183 <ø> (ø)`	⬇️

Impacted Files	Coverage Δ	Complexity Δ
core/js/sharedialogview.js	`78.6% <57.14%> (-0.19%)`	`0 <0> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d1a344...4644552. Read the comment docs.

phil-davis · 2019-06-03T11:40:40Z

tests/acceptance/features/bootstrap/FederationContext.php

@@ -98,6 +118,32 @@ public function userFromServerHasSharedWithUserFromServer(
 		);
 	}

+	/**
+	 * @Given /^user "([^"]*)" from server "(LOCAL|REMOTE)" has shared "([^"]*)" with user "([^"]*)" from server "(LOCAL|REMOTE)" with permissions (.*)$/


This is specially useful for setting up a share on the remote (federated) server, and giving it some permissions.
We want to use the API to set up stuff on the remote server, rather than the webUI, because we do not want to depend on particular details of the webUI on the remote server. (The remote server might be running some older release/code that has a bit different webUI behaviour, but it should have compatible API behaviour within the same major version)

In the case of this particular PR, the webUI dropdown sharing list has changed its format/text a bit, and so trying to run the new webUI sharing acceptance test code against a remote server without the PR would fail.

micbar · 2019-06-07T20:26:28Z

@phil-davis Great Work! Keep on :-)

phil-davis · 2019-06-11T11:25:06Z

@individual-it this is ready for review of the acceptance test changes.

individual-it

tests look good to me

phil-davis · 2019-06-11T11:58:51Z

@pmaier1 and anyone else who cares, this is "good to go" from a technical POV.
If you are happy with it, then we can make the forward-port to master and merge both PRs.
And I guess it will be released in the next minor release?
(not for 10.2.1 ?)

phil-davis · 2019-06-11T13:19:15Z

Forward port to master is PR #35486

pmaier1 · 2019-06-11T13:34:49Z

And I guess it will be released in the next minor release?
(not for 10.2.1 ?)

Yes, something for the next minor.

phil-davis · 2019-06-12T01:29:37Z

See comment on forward port about codecov #35486 (comment)
Needs to be decided before merging here, so that the forward port and this stable10 PR are the same.

…e autocomplete

…ossibleToShareFileFolderUsingTheWebUI

phil-davis · 2019-06-13T03:28:37Z

I cherry-picked commit "add js test for remote share with server" from the master PR #35486

DeepDiver1975 added the 3 - To Review label May 31, 2019

DeepDiver1975 requested a review from pmaier1 May 31, 2019 15:23

DeepDiver1975 self-assigned this May 31, 2019

DeepDiver1975 force-pushed the bugfix/35098 branch from 1cf1fef to 3f1a72d Compare May 31, 2019 15:25

pmaier1 approved these changes May 31, 2019

View reviewed changes

DeepDiver1975 changed the title ~~use a multi line approach to display share autocomplete~~ [stable10] use a multi line approach to display share autocomplete May 31, 2019

phil-davis self-assigned this Jun 3, 2019

phil-davis force-pushed the bugfix/35098 branch from 3f1a72d to f11dd61 Compare June 3, 2019 06:50

pmaier1 mentioned this pull request Jun 3, 2019

[feature/sharing-user-groups] Implementation of Sharing with Users, Groups and Remote Users, Public Links owncloud/ios-app#358

Merged

44 tasks

phil-davis force-pushed the bugfix/35098 branch from f11dd61 to 69c4209 Compare June 3, 2019 09:19

phil-davis reviewed Jun 3, 2019

View reviewed changes

phil-davis force-pushed the bugfix/35098 branch 6 times, most recently from 0eff143 to 8f732bf Compare June 7, 2019 09:50

micbar added this to the development milestone Jun 7, 2019

phil-davis force-pushed the bugfix/35098 branch 2 times, most recently from 9358885 to c6a148d Compare June 11, 2019 11:04

phil-davis requested a review from individual-it June 11, 2019 11:18

individual-it approved these changes Jun 11, 2019

View reviewed changes

karakayasemi mentioned this pull request Jun 11, 2019

use a multi line approach to display share autocomplete #35486

Merged

10 tasks

phil-davis mentioned this pull request Jun 11, 2019

[master] use a multi line approach to display share autocomplete #35487

Closed

phil-davis mentioned this pull request Jun 11, 2019

Cannot share with user and group having same name #35488

Closed

phil-davis force-pushed the bugfix/35098 branch from b010b73 to 88694a3 Compare June 11, 2019 16:05

DeepDiver1975 and others added 8 commits June 13, 2019 09:11

fixes #35098 - use a multi line approach to display share autocomplete

e2582f6

Adjust webUI acceptance tests for multi-line approach to display shar…

e126438

…e autocomplete

Set up remote server share with permissions using API

394e466

Refactor theUserSharesFileFolderWithUserOrGroupUsingTheWebUI

0f102ed

Adjust ShouldBeListed steps

83f2d17

Adjust theUsersOwnNameShouldNotBeListedInTheAutocompleteList

ed4b8a9

Do not specially handle case when shareWith is null in itShouldNotBeP…

b2a2cb4

…ossibleToShareFileFolderUsingTheWebUI

add js test for remote share with server

4644552

phil-davis force-pushed the bugfix/35098 branch from 88694a3 to 4644552 Compare June 13, 2019 03:27

micbar merged commit b214052 into stable10 Jun 14, 2019

delete-merged-branch bot deleted the bugfix/35098 branch June 14, 2019 11:57

This was referenced Jun 17, 2019

Adjust expected sharing dialog box text owncloud/guests#336

Merged

Adjust guest sharing dropdown text owncloud/guests#337

Merged

Acceptance tests for release 10.2.1 #35562

Merged

phil-davis added the release:10.3 label Aug 2, 2019

patrickjahns added the changelog-added label Aug 12, 2019

davitol mentioned this pull request Sep 3, 2019

10.3 - Changelog test Results #36142

Closed

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[stable10] use a multi line approach to display share autocomplete #35397

[stable10] use a multi line approach to display share autocomplete #35397

DeepDiver1975 commented May 31, 2019 •

edited

Loading

pmaier1 left a comment

micbar commented Jun 2, 2019

phil-davis commented Jun 3, 2019

codecov bot commented Jun 3, 2019

codecov bot commented Jun 3, 2019 •

edited

Loading

phil-davis Jun 3, 2019

phil-davis Jun 3, 2019 •

edited

Loading

micbar commented Jun 7, 2019

phil-davis commented Jun 11, 2019 •

edited

Loading

individual-it left a comment

phil-davis commented Jun 11, 2019

phil-davis commented Jun 11, 2019

pmaier1 commented Jun 11, 2019

phil-davis commented Jun 12, 2019

phil-davis commented Jun 13, 2019

[stable10] use a multi line approach to display share autocomplete #35397

[stable10] use a multi line approach to display share autocomplete #35397

Conversation

DeepDiver1975 commented May 31, 2019 • edited Loading

Description

Related Issue

How Has This Been Tested?

Screenshots (if appropriate):

Federated or Guest

Group

With additional user information

Types of changes

Checklist:

Open tasks:

pmaier1 left a comment

Choose a reason for hiding this comment

micbar commented Jun 2, 2019

phil-davis commented Jun 3, 2019

codecov bot commented Jun 3, 2019

Codecov Report

codecov bot commented Jun 3, 2019 • edited Loading

Codecov Report

phil-davis Jun 3, 2019

Choose a reason for hiding this comment

phil-davis Jun 3, 2019 • edited Loading

Choose a reason for hiding this comment

micbar commented Jun 7, 2019

phil-davis commented Jun 11, 2019 • edited Loading

individual-it left a comment

Choose a reason for hiding this comment

phil-davis commented Jun 11, 2019

phil-davis commented Jun 11, 2019

pmaier1 commented Jun 11, 2019

phil-davis commented Jun 12, 2019

phil-davis commented Jun 13, 2019

DeepDiver1975 commented May 31, 2019 •

edited

Loading

codecov bot commented Jun 3, 2019 •

edited

Loading

phil-davis Jun 3, 2019 •

edited

Loading

phil-davis commented Jun 11, 2019 •

edited

Loading