Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround mink selenium2 driver regressions #32144

Merged
merged 2 commits into from
Jul 24, 2018

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jul 24, 2018

Description

  1. Catch StaleElementReference that is now thrown (unfortunately/wrongly) by fillField
  2. Implement our own code that will do a setValue because the existing code in MinkSelenium2Driver does not work in auto-complete fields.

Related Issue

Motivation and Context

Fix webUI tests that are broken by a regression in the MinkSelenium2Driver

How Has This Been Tested?

  • run failing tests locally
  • CI will check it all

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis
Copy link
Contributor Author

Backport stable10 #32145

@phil-davis phil-davis force-pushed the workaround-MinkSelenium2Driver-regressions branch from 424bf9b to ba9200c Compare July 24, 2018 09:16
@codecov
Copy link

codecov bot commented Jul 24, 2018

Codecov Report

Merging #32144 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #32144   +/-   ##
=========================================
  Coverage     63.89%   63.89%           
  Complexity    18546    18546           
=========================================
  Files          1170     1170           
  Lines         69728    69728           
  Branches       1267     1267           
=========================================
  Hits          44555    44555           
  Misses        24804    24804           
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 52.81% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.16% <ø> (ø) 18546 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1097910...ba9200c. Read the comment docs.

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MinkSelenium2Driver recent change breaks webUI tests
2 participants