Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock behat/mink-selenium2-driver dev-master commit #32111

Closed
wants to merge 1 commit into from

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jul 20, 2018

Because there is a later commit that breaks UI tests and needs investigation.

https://github.com/minkphp/MinkSelenium2Driver/commits/master

Things work at:
minkphp/MinkSelenium2Driver@93474c6

But break at:
minkphp/MinkSelenium2Driver@d8adafd

Related issue: #32143

Verified

This commit was signed with the committer’s verified signature.
phil-davis Phil Davis
@phil-davis
Copy link
Contributor Author

After changing composer.json I did:

composer update behat/mink-selenium2-driver

and unfortunately it has still put the later commit id into composer.lock

Need to investigate...

@phil-davis
Copy link
Contributor Author

Not needed. Workaround for the mink-selenium2-driver regressions is now in place - see issue #32143 for details.

@phil-davis phil-davis closed this Jul 25, 2018
@phil-davis phil-davis deleted the lock-mink-selenium2-driver-commmit-hash branch July 25, 2018 02:54
@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant