Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run files_external owncloud tests with owncloud 10 #30733

Closed
wants to merge 1 commit into from

Conversation

patrickjahns
Copy link
Contributor

Description

Execute files_external tests with owncloud

This PR currently will fail for testCheckUpdate

public function testCheckUpdate() {
if ($this->instance instanceof \OC\Files\Storage\Wrapper\Wrapper) {
$this->markTestSkipped('Cannot test update check on wrappers');
}
$textFile = \OC::$SERVERROOT . '/tests/data/lorem.txt';
$watcher = $this->instance->getWatcher();
$watcher->setPolicy(Watcher::CHECK_ALWAYS);
$this->instance->file_put_contents('/lorem.txt', file_get_contents($textFile));
$this->assertTrue($watcher->checkUpdate('/lorem.txt'), 'Update detected');
$this->assertFalse($watcher->checkUpdate('/lorem.txt'), 'No update');
}

Reason:
We compare local cached "permissions" with sharePermissions from remote:

return $sharePermissions !== $cachedData['permissions'];

https://github.com/owncloud/core/blob/master/lib/private/Files/Storage/DAV.php#L781

Screenshot from data tracked down in xdebug
image

I am unsure how {http://open-collaboration-services.org/ns}share-permissions correlates with the cached permissions field.
But it seems we do not cache it anywhere? @PVince81

Motivation and Context

Jenkins 🔫

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@patrickjahns
Copy link
Contributor Author

@DeepDiver1975
assigned you to help with this

@patrickjahns
Copy link
Contributor Author

@micbar
As discussed in person right now - when migrating webdav testing over to using a ownCloud 10 backend I stumpled upon this issue. This might be related to the case you are currently investigating

@PVince81 PVince81 added this to the backlog milestone Feb 7, 2019
@PVince81 PVince81 mentioned this pull request Mar 11, 2019
6 tasks
@PVince81
Copy link
Contributor

issue created: #34735

I'd be surprised if the OC and SFTP fail as they used to pass a while ago as far as I remember

@micbar
Copy link
Contributor

micbar commented Jun 7, 2019

@patrickjahns is this still needed?

What are the next steps?

@patrickjahns
Copy link
Contributor Author

Similar issue documented by QA here #35660

@DeepDiver1975
Copy link
Member

As discussed in #35777 the master branch will from now on hold the ownCloud 10 codebase.

This PR targetted ownCloud 11 which is postponed to a far distant future.

Because of that I'm closing this PR and kindly ask you to re-submit this PR in a few days.

Thanks a lot for your patience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants