occ app:list filter

[phil-davis]

Description

• Allow a search-pattern to be entered as a parameter to oc app:list so the user can filter the list to just matching app names.
• only print the "Enabled:" and "Disabled:" sections of output if they have at least 1 app in them
• make use of this in the integration tests run.sh script to preserve the existing state of the testing app

Related Issue

#28638

Motivation and Context

• it is handy for a script to have some way to know if an app is currently enabled or disabled
• it could be handy for sysadmins to be able to filter the output of occ app:list, that possibility comes for free here

How Has This Been Tested?

• enable the testing app
• run some integration tests
• verify that the testing app is still enabled
• disable the testing app
• run some integration tests
• verify that the testing app is disabled

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[DeepDiver1975]

to -> of

[phil-davis]

I used similar words to https://github.com/owncloud/core/blob/master/core/Command/User/ListUsers.php#L51

I could be more verbose and say:

Restrict the list of apps to those whose name matches the given regular expression

[phil-davis]

Note: I would like to make use of this from firewall testing scripts, to avoid the firewall app getting disabled on me all the time. There are probably other app testing scripts that could also make use of this to improve their friendliness.

[PVince81]

what admin is patient enough to type "--search-pattern" ? please make that "--search"

[phil-davis]

It is an argument, not a command option:

occ app:list firewall

is all that is needed
similar to occ user:list

[phil-davis]

@DeepDiver1975 @PVince81 questions addressed, I think. Please re-review.

[PVince81]

👍

[phil-davis]

Backport to stable10 #28653

[phil-davis]

Doc in owncloud-archive/documentation#3311

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.