Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load the app in the migration service. This allows execution of app c… #28388

Merged
merged 1 commit into from
Jul 13, 2017
Merged

Load the app in the migration service. This allows execution of app c… #28388

merged 1 commit into from
Jul 13, 2017

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Jul 13, 2017 •
edited
Loading

…ode in migrations

Description

Migration steps of an app can include code of the app itself - e.g. mapper classes for database access.
These classes cannot be loaded if the app is not loaded.

This change fixes this.

How Has This Been Tested?

owncloud/oauth2@9f75e0a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the development milestone Jul 13, 2017
@DeepDiver1975 DeepDiver1975 requested a review from PVince81 July 13, 2017 08:27
PVince81
PVince81 approved these changes Jul 13, 2017
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DeepDiver1975 DeepDiver1975 merged commit 56fd80e into master Jul 13, 2017
@DeepDiver1975 DeepDiver1975 deleted the load-app-before-executing-migrations branch July 13, 2017 11:19
@DeepDiver1975 DeepDiver1975 mentioned this pull request Jul 13, 2017
Merged
@PVince81
Copy link
Contributor

@sharidas has a weird issue that starts with this commit: it looked like the activity app was not able to initialize some code because it was receiving a null IUserSession. Strangely I cannot reproduce this, so not sure if there is some loading order involved.

@DeepDiver1975
Copy link
Member Author

:face_palm: this code base is killing me ....

@DeepDiver1975
Copy link
Member Author

there is another issue with this - update is no longer possible because loading an app which needs update causes NeedsUpdateException ....

@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees
No one assigned
Labels
3 - To Review status/STALE
Projects
None yet
Milestone
10.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@DeepDiver1975 @PVince81 @ownclouders