Catch the AutoloadNotAllowedException also for legacy jobs #23901
Conversation
* same as #18839 for legacy jobs * avoids spamming the log with useless entries
|
By analyzing the blame information on this pull request, we identified @icewind1991 and @DeepDiver1975 to be potential reviewers |
|
@Xenopathic @nickvergessen @benediktg @LukasReschke Please review :) |
|
👍 |
| call_user_func($argument); | ||
| } | ||
| } catch (AutoloadNotAllowedException $e) { | ||
| // job is from a disabled app, ignore |
There was a problem hiding this comment.
That's the idea - we don't want to log it. That's what is done today and what #18839 also removed ;)
There was a problem hiding this comment.
Why wouldn't you want to log this. If it happens and you get such an entry, just delete it manually and it wont show up again?
There was a problem hiding this comment.
So we outsource our own fault of properly unregister background jobs to the user? 😕
There was a problem hiding this comment.
Well silently ignoring and always looping over is at least not the right way...
There was a problem hiding this comment.
Then we should drop it somehow.
|
👍 looks good |
|
great catch. please backport |
|
stable9: #23930 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This was reported by @benediktg in owncloud/files_antivirus#98 (comment)
@karlitschek I would like to backport this to stable9, is this okay?