Updated color generator #23768
Merged
Updated color generator #23768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @rullzer, @Kondou-ger and @MorrisJobke to be potential reviewers |
This was referenced Apr 4, 2016
Merged
|
Tested and works 👍 cc @owncloud/designers |
|
This rather calls for a review from @owncloud/javascript folks. |
| var hue = parseInt(hsl[0] * 360); | ||
| this.css('background-color', 'hsl('+hue+', '+sat+'%, '+lum+'%)'); | ||
| return [parseInt(hsl[0] * 360), sat, lum]; | ||
| } |
There was a problem hiding this comment.
LOL, at least now you’re honest. ;D
skjnldsv
force-pushed
the
skjnldsv-color-generator-edit
branch
from
840fc30 to
a2c730e
Compare
Separated the main function to allow special use without dom manipulation.
skjnldsv
force-pushed
the
skjnldsv-color-generator-edit
branch
from
a2c730e to
28571e6
Compare
|
👍 |
|
What about some unit tests? |
|
This function is already tested in the avatar test I think :) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated the main function to allow special use without dom manipulation.
Because the imageplaceholder function include css styling and dom manipulation, we might want to only convert a hash to HSL for some different uses than avatars. (like the contact header for example)
This PR separated the functions and created a new one allowing devs to use the
"a6741a86aded5611a8e46ce16f2ad646".toHsl()function and get the raw hsl parameters.