Use boxes for system tags, shorten permission text #21958
Conversation
|
By analyzing the blame information on this pull request, we identified @nickvergessen to be a potential reviewer |
|
nice 👍 |
|
Tested and works, only one minor thing:
|
| scope = t('core', 'not assignable'); | ||
| } | ||
| if (!tag.userVisible) { | ||
| // invisible also implicitly means not assignable |
There was a problem hiding this comment.
right, forgot to check that in the tag manager
|
@MorrisJobke yeah I probably removed one margin too much. Was expecting @jancborchardt to do his styling magic anyway. |
| @@ -62,16 +62,12 @@ | |||
| } | |||
|
|
|||
| .systemtags-select2-container .select2-choices .select2-search-choice { | |||
There was a problem hiding this comment.
just remove this completly? Or whats the problem with it?
There was a problem hiding this comment.
We need the padding-left because normally select2 has little "close" buttons, but we removed them.
So the padding is needed.
Permission text now doesn't appear when all permissions are there, or shows as "invisible" or "not assignable", which should better cover all use cases. Changed select2 style to use boxes in the input field.
PVince81
force-pushed
the
systemtags-style
branch
from
b99c760 to
1473e15
Compare
|
I fixed the input field, it looks better now. I also did some experiments with collapsing the field locally, but there's trouble with the dropdown position and it doesn't feel right. Will continue the collapsing this separately. Please review. |
|
👍 looks fancy and nice |
|
Yep 👍 |
Use boxes for system tags, shorten permission text
|
Very cool, good fixes @PVince81! :) |
Permission text now doesn't appear when all permissions are there, or
shows as "invisible" or "not assignable", which should better cover all
use cases.
Changed select2 style to use boxes in the input field.
As admin:
As user:
Please review @nickvergessen @jancborchardt
@jancborchardt feel free to use your styling
hammerbrush and push on this PR (separate PR is fine too)Note: we'll also have to talk about how to deal with wrapping.