Only load app routes if the app has already been loaded [re-merge] #18374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new inspection was created. |
|
🚀 Test PASSed.🚀 |
|
Sounds good 👍 |
10 tasks
|
I did some some testing (uploading, downloading, browsing, sharing, OCS API) and all seems to work fine 👍 |
MorrisJobke
added a commit
that referenced
this pull request
Aug 19, 2015
Only load app routes if the app has already been loaded [re-merge]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18109 was merged, but then reverted since we didn't want to have the whole mess, but the problem has come back again. During an upgrade, no apps are loaded, but the Router is used somewhere and so app routes are still loaded.
If an app isn't loaded when the router tries to load routes, it marks itself as 'not loaded', so the next time a route is requested any non-loaded routes attempt to get loaded again.
cc @icewind1991 @DeepDiver1975 @LukasReschke @PVince81
currently blocking #15914, so I'd appreciate a quick resolution on this 😄