Preserve cache data when doing a cross storage move

[icewind1991]

By preserving the file id we keep favorites and shares, and the sync client can properly detect it as a move and doesn't have to re-download the file.

To test:

• Create a share or external storage so we have 2 storages to move between.
• Favorite a file
• Move the file to the other storage
• Check that the file is still a favorite

cc @DeepDiver1975 @MorrisJobke

[PVince81]

Wow, that is cool.
Ref fileid stability ticket: #13310

[karlitschek]

cool. Would be great to have this in 👍

[PVince81]

@icewind1991 I assume you're still working on this as the label is still "4 - Developing"

[icewind1991]

Test Result (2 failures / +2)
Test\BackgroundJob\DeleteOrphanedSharesJobTest.testClearShares
Test\BackgroundJob\DeleteOrphanedSharesJobTest.testKeepNonFileShares

Unrelated?

[DeepDiver1975]

Unrelated?

yes - seen in other prs as well

[icewind1991]

So merge this?

[DeepDiver1975]

So merge this?

after review - yes

[PVince81]

(the fix for the failing test was merged to master)

[PVince81]

Great work. Really cool 😄

• move to external storage and back again: favorite info preserved
• move to shared folder as recipient

[PVince81]

Fixes #13274
Fixes #13307

[scrutinizer-notifier]

A new inspection was created.

[icewind1991]

move to shared folder as recipient 🚫 FAIL: the cache entry is created twice, once is the correct file (still favorite) and another one gets created

Fixed

[ghost]

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/11471/
🚀 Test PASSed.🚀

[PVince81]

I moved a favorited burger picture around in:

• ext storage mount points
• shared storages (as recipient)
• shares from mount points
• local folders

And also carried the burger pic inside a favorited "dir" folder between several of such folders.

The favorite information didn't get lost 👍

[MorrisJobke]

Tested and works 👍

[PVince81]

Regression: #21236

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.