php-cs-fixer 3.9.1 and 3.9.2 is reporting code-style failures

[phil-davis]

https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/tag/v3.9.1 was released a few hours ago.

It reports a lot of new code-style failures.

Needs investigation to see if these are,
real (the code-style checks were genuinely improved, the code should be adjusted) or;
regressions in php-cs-fixer (php-cs-fixer needs to be patched, or we pin our CI to the previous release https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/tag/v3.8.0 )

Related issue PHP-CS-Fixer/PHP-CS-Fixer#6470

[phil-davis]

core and app PRs are failing, e.g.
#40195
owncloud/encryption#351

This PR is adjusting the code-style in core: #40196

[phil-davis]

I made owncloud/coding-standard#26 and coding-standard release https://github.com/owncloud/coding-standard/releases/tag/3.0.3 that pins php-cs-fixer to the previous release 3.8.0 for now.

That will let CI pass so that other things can move forward.

[phil-davis]

php-cs-fixer is pinned to 3.8.0 for now. There is no big rush to help upstream fix the problems. I will make some upstream contribution, but no hurry.

[phil-davis]

I changed this to Blocked. This is an upstream issue, so no need to put it on our project board any more. As an upstream contribution we (me?) could help them track down the problems with newer php-cs-fixer releases. It would be nice to unpin php-cs-fixer from 3.8.0 "some day" - but actually there is no pressing need.

[phil-davis]

This was resolved upstream.
See PR owncloud/coding-standard#35 - we are using cs-fixer 3.13 at the moment.