Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php-cs-fixer 3.9.* has issues #29

Closed
phil-davis opened this issue Jul 12, 2022 · 2 comments
Closed

php-cs-fixer 3.9.* has issues #29

phil-davis opened this issue Jul 12, 2022 · 2 comments
Assignees

Comments

@phil-davis
Copy link
Contributor

I have been making patch releases of owncloud/coding-standard that pin various versions of php-cs-fixer 3.9.*

There are still issues with php-cs-fixer 3.9.*, so the latest owncloud/coding-standard is back to using php-cs-fixer 3.8.0

core issue owncloud/core#40197 relates to this. See that for more discussion and links.

I will keep this coding-standard issue open until I am able to bump php-cs-fixer to a new good release.

@phil-davis phil-davis self-assigned this Jul 12, 2022
@phil-davis
Copy link
Contributor Author

3.11.0 looks better - see PR owncloud/core#40211

That needs PHP 7.4. I will leave it until after core 10.11.0 is released. And probably we can drop PHP 7.3 anyway, and then apply the newest php-cs-fixer version.

coding-standard master branch has PR #34 which pine coding-standard to 3.11.0. So that can be released when we are ready.

@phil-davis
Copy link
Contributor Author

We are using later php-cs-fixer releases successfully.
I bumped to php-cs-fixer 3.16 today and made coding-standard 4.1.0 release. That is passing for at least core and ocis:
owncloud/core#40780
owncloud/ocis#6266

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant