Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to have unit tests for transfer ownership #31954

Closed
sharidas opened this issue Jun 29, 2018 · 2 comments
Closed

Need to have unit tests for transfer ownership #31954

sharidas opened this issue Jun 29, 2018 · 2 comments
Labels
technical debt
Milestone
maybe some day

Comments

@sharidas
Copy link
Contributor

We need to have unit tests for the change in tranfer ownership command. This does affect the code coverage result.
@sharidas sharidas changed the title Need to have php unit for transfer ownership Need to have unit tests for transfer ownership Jun 29, 2018
@ownclouders
Copy link
Contributor

GitMate.io thinks the contributor most likely able to help you is @PVince81.

Possibly related issues are #13355 (Transfer share ownership to other user), #29608 (Transfer ownership trashbin), #29540 (Transfer-ownership keep versions), #26523 (Transfer ownership path already shared), and #9879 (Need info about backgroundjob.php).

@PVince81 PVince81 added this to the maybe some day milestone Jul 2, 2018
@karakayasemi
Copy link
Contributor

Some tests are added with #36222.
According to https://codecov.io/gh/owncloud/core/src/27d4865685bc7e76997f3f50e444ff54f86d3d5d/apps/files/lib/Command/TransferOwnership.php coverage is around 81%. I guess we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical debt
Projects
None yet
Milestone
maybe some day
Development

No branches or pull requests
4 participants
@PVince81 @sharidas @karakayasemi @ownclouders