Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

occ command to adjust filecache checksum #30951

Closed
PVince81 opened this issue Mar 28, 2018 · 8 comments
Closed

occ command to adjust filecache checksum #30951

PVince81 opened this issue Mar 28, 2018 · 8 comments
Assignees
Labels
enhancement p1-urgent Critical issue, need to consider hotfix with just that issue
Milestone

Comments

@PVince81
Copy link
Contributor

In some special cases (not reproducible) it can happen that the checksum in oc_filecache doesn't match the data on disk. This causes the desktop client to refuse working with said file.

If an admin can confirm that the data on disk is correct, they need a way to reset the checksums.

For this we should provide an occ command that scans through all files and detects wrong checksums. This could likely take a very long time as it needs to open all files to recompute the checksums ! I suggest to add a --path parameter so an admin can provide a more focussed scan (see --path argument like for occ files:scan) when they know in what folder most broken checksums are located.

Another alternative would be to only delete the wrong checksums and let the server recompute during the next download.

@IljaN @jnweiger @felixboehm

@PVince81 PVince81 added enhancement p1-urgent Critical issue, need to consider hotfix with just that issue labels Mar 28, 2018
@PVince81 PVince81 added this to the development milestone Mar 28, 2018
@PVince81
Copy link
Contributor Author

PVince81 commented Mar 28, 2018

Note: when user-key encryption is enabled the command can only work if a recovery key is specified. Else there is no way for the occ command to decrypt the files to compute the checksums to verify them. (see how decrypt-all).

For the first version I suggest ignoring user-key encryption and add a warning.

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #24494 (occ command to clear all locks), #30177 (Kill occ command maintenance:createjs), #25970 (occ command to migrate data folder), #28940 (add occ command to flush distributed cache), and #23380 (Occ command not working).

@IljaN
Copy link
Contributor

IljaN commented Apr 4, 2018

  • Should also work with ObjectStore

IljaN added a commit that referenced this issue Apr 4, 2018
IljaN added a commit that referenced this issue Apr 5, 2018
IljaN added a commit that referenced this issue Apr 5, 2018
@IljaN
Copy link
Contributor

IljaN commented Apr 5, 2018

Could not test with objectstore because of: https://github.com/owncloud/objectstore/issues/88

IljaN added a commit that referenced this issue Apr 5, 2018
IljaN added a commit that referenced this issue Apr 5, 2018
IljaN added a commit that referenced this issue Apr 5, 2018
IljaN added a commit that referenced this issue Apr 7, 2018
@PVince81
Copy link
Contributor Author

where is the PR ? please link

@PVince81
Copy link
Contributor Author

found it, PR here: #31008

IljaN added a commit that referenced this issue Apr 11, 2018
IljaN added a commit that referenced this issue Apr 11, 2018
(cherry picked from commit 7a27e5c)
@IljaN
Copy link
Contributor

IljaN commented Apr 11, 2018

Forward Port: #31082

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement p1-urgent Critical issue, need to consider hotfix with just that issue
Projects
None yet
Development

No branches or pull requests

3 participants