Alter some critical fields to BigInt

owncloud · Jul 12, 2017 · bf00edd · bf00edd
1 parent bf286dd
commit bf00edd
Show file tree

Hide file tree

Showing 6 changed files with 67 additions and 8 deletions.
diff --git a/apps/dav/appinfo/Migrations/Version20170711193427.php b/apps/dav/appinfo/Migrations/Version20170711193427.php
@@ -0,0 +1,32 @@
+<?php
+namespace OCA\DAV\Migrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\DBAL\Types\Type;
+use OCP\Migration\ISchemaMigration;
+
+/**
+ * Updates column type from integer to bigint
+ */
+class Version20170711193427 implements ISchemaMigration {
+
+	public function changeSchema(Schema $schema, array $options) {
+		$prefix = $options['tablePrefix'];
+
+		if ($schema->hasTable("${prefix}properties")) {
+			$table = $schema->getTable("{$prefix}properties");
+
+			$idColumn = $table->getColumn('id');
+			if ($idColumn){
+				$idColumn->setType(Type::getType(Type::BIGINT));
+				$idColumn->setOptions(['length' => 20]);
+			}
+
+			$fileidColumn = $table->getColumn('fileid');
+			if ($fileidColumn){
+				$fileidColumn->setType(Type::getType(Type::BIGINT));
+				$fileidColumn->setOptions(['length' => 20]);
+			}
+		}
+	}
+}
diff --git a/apps/federatedfilesharing/appinfo/database.xml b/apps/federatedfilesharing/appinfo/database.xml
@@ -19,13 +19,13 @@ the servers (e.g. permissions change, unshare,...)
 				<name>share_id</name>
 				<type>integer</type>
 				<notnull>true</notnull>
-				<length>4</length>
+				<length>10</length>
 			</field>
 			<field>
 				<name>remote_id</name>
 				<type>integer</type>
 				<notnull>true</notnull>
-				<length>4</length>
+				<length>10</length>
 				<comments>share ID at the remote server</comments>
 			</field>
 			<index>

diff --git a/apps/files_sharing/appinfo/database.xml b/apps/files_sharing/appinfo/database.xml
@@ -13,7 +13,7 @@
 				<default>0</default>
 				<notnull>true</notnull>
 				<autoincrement>1</autoincrement>
-				<length>4</length>
+				<length>10</length>
 			</field>
 			<field>
 				<name>remote</name>
@@ -27,7 +27,7 @@
 				<type>integer</type>
 				<default>-1</default>
 				<notnull>true</notnull>
-				<length>4</length>
+				<length>10</length>
 			</field>
 			<field>
 				<name>share_token</name>

diff --git a/apps/files_trashbin/appinfo/database.xml b/apps/files_trashbin/appinfo/database.xml
@@ -19,7 +19,7 @@
 		  <default>0</default>
 		  <notnull>true</notnull>
 		  <autoincrement>1</autoincrement>
-		  <length>4</length>
+		  <length>10</length>
 	  </field>
 
    <field>

diff --git a/core/Migrations/Version20170711191432.php b/core/Migrations/Version20170711191432.php
@@ -0,0 +1,26 @@
+<?php
+namespace OC\Migrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\DBAL\Types\Type;
+use OCP\Migration\ISchemaMigration;
+
+/**
+ * Updates column type in the share table from integer to bigint
+ */
+class Version20170711191432 implements ISchemaMigration {
+
+	public function changeSchema(Schema $schema, array $options) {
+		$prefix = $options['tablePrefix'];
+
+		if ($schema->hasTable("${prefix}share")) {
+			$table = $schema->getTable("{$prefix}share");
+
+			$fileSourceColumn = $table->getColumn('file_source');
+			if ($fileSourceColumn){
+				$fileSourceColumn->setType(Type::getType(Type::BIGINT));
+				$fileSourceColumn->setOptions(['length' => 20]);
+			}
+		}
+	}
+}
diff --git a/db_structure.xml b/db_structure.xml
@@ -153,6 +153,7 @@
 			<field>
 				<name>root_id</name>
 				<type>integer</type>
+				<length>10</length>
 				<notnull>true</notnull>
 			</field>
 
@@ -278,7 +279,7 @@
 				<default>0</default>
 				<notnull>true</notnull>
 				<autoincrement>1</autoincrement>
-				<length>4</length>
+				<length>10</length>
 			</field>
 
 			<!-- Foreign Key storages::numeric_id -->
@@ -312,7 +313,7 @@
 				<type>integer</type>
 				<default></default>
 				<notnull>true</notnull>
-				<length>4</length>
+				<length>10</length>
 			</field>
 
 			<field>
@@ -984,7 +985,7 @@
 			<default>0</default>
 			<notnull>true</notnull>
 			<unsigned>true</unsigned>
-			<length>4</length>
+			<length>10</length>
 		</field>
 
 		<!-- Foreign Key vcategory::id -->