Skip to content

Commit

Permalink
Merge pull request #36465 from owncloud/fix-kerberos
Browse files Browse the repository at this point in the history
Request->getHeader('Authentication') returns ''
  • Loading branch information
micbar authored Nov 25, 2019
2 parents 9c64155 + e1daab7 commit b36724f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion apps/dav/lib/Connector/Sabre/Auth.php
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ private function auth(RequestInterface $request, ResponseInterface $response) {
//Fix for broken webdav clients
($this->userSession->isLoggedIn() && $this->session->get(self::DAV_AUTHENTICATED) === null) ||
//Well behaved clients that only send the cookie are allowed
($this->userSession->isLoggedIn() && $this->session->get(self::DAV_AUTHENTICATED) === $this->userSession->getUser()->getUID() && $request->getHeader('Authorization') === null)
($this->userSession->isLoggedIn() && $this->session->get(self::DAV_AUTHENTICATED) === $this->userSession->getUser()->getUID() && ($request->getHeader('Authorization') === null || $request->getHeader('Authorization') === ''))
) {
$user = $this->userSession->getUser();
$this->checkAccountModule($user);
Expand Down
5 changes: 5 additions & 0 deletions changelog/unreleased/36465
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: the authentication header can also hold an empty string

In some setups a not set authentication header can not only hold null but also an empty string

https://github.com/owncloud/core/pull/36465

0 comments on commit b36724f

Please sign in to comment.