Skip to content

Commit

Permalink
Apply suggestions from code review of 39406
Browse files Browse the repository at this point in the history
  • Loading branch information
phil-davis authored Oct 25, 2021
1 parent 2041127 commit 0efa76b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ Feature: share resources where the sharee receives the share in multiple ways


@skipOnOcV10 @issue-39347
Scenario Outline: Share reciever renames the recieved group share and share same folder through user share again
Scenario Outline: Share receiver renames the received group share and shares same folder through user share again
Given using OCS API version "<ocs_api_version>"
And group "grp" has been created
And user "Brian" has been added to group "grp"
Expand All @@ -555,7 +555,7 @@ Feature: share resources where the sharee receives the share in multiple ways
| 2 |

@skipOnOcV10 @issue-39347
Scenario Outline: Share reciever renames the recieved group share and declines another share of same folder through user share again
Scenario Outline: Share receiver renames the received group share and declines another share of same folder through user share again
Given using OCS API version "<ocs_api_version>"
And group "grp" has been created
And user "Brian" has been added to group "grp"
Expand All @@ -577,7 +577,7 @@ Feature: share resources where the sharee receives the share in multiple ways
| 2 |

@skipOnOcV10 @issue-39347
Scenario Outline: Share reciever renames a group share and recieves same resource through user share with additional permissions
Scenario Outline: Share receiver renames a group share and receives same resource through user share with additional permissions
Given using OCS API version "<ocs_api_version>"
And group "grp" has been created
And user "Brian" has been added to group "grp"
Expand All @@ -600,7 +600,7 @@ Feature: share resources where the sharee receives the share in multiple ways
| 2 |

@skipOnOcV10 @issue-39347
Scenario Outline: Share reciever renames a group share and recieves same resource through user share with less permissions
Scenario Outline: Share receiver renames a group share and receives same resource through user share with less permissions
Given using OCS API version "<ocs_api_version>"
And group "grp" has been created
And user "Brian" has been added to group "grp"
Expand All @@ -616,7 +616,7 @@ Feature: share resources where the sharee receives the share in multiple ways
Then as "Brian" folder "Shares/parent" should not exist
And as "Brian" folder "Shares/sharedParent" should exist
And as "Brian" file "Shares/sharedParent/child/lorem.txt" should exist
Then user "Brian" should be able to delete file "Shares/parent/child/lorem.txt"
And user "Brian" should be able to delete file "Shares/parent/child/lorem.txt"
Examples:
| ocs_api_version |
| 1 |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Feature: share resources where the sharee receives the share in multiple ways
| Alice |
| Brian |

Scenario Outline: Share reciever renames the recieved group share and share same folder through user share again
Scenario Outline: Share receiver renames the received group share and shares same folder through user share again
Given using OCS API version "<ocs_api_version>"
And group "grp" has been created
And user "Brian" has been added to group "grp"
Expand All @@ -33,7 +33,7 @@ Feature: share resources where the sharee receives the share in multiple ways
| 2 |


Scenario Outline: Share reciever renames the recieved group share and declines another share of same folder through user share again
Scenario Outline: Share receiver renames the received group share and declines another share of same folder through user share again
Given using OCS API version "<ocs_api_version>"
And group "grp" has been created
And user "Brian" has been added to group "grp"
Expand All @@ -54,7 +54,7 @@ Feature: share resources where the sharee receives the share in multiple ways
| 1 |
| 2 |

Scenario Outline: Share reciever renames a group share and recieves same resource through user share with additional permissions
Scenario Outline: Share receiver renames a group share and receives same resource through user share with additional permissions
Given using OCS API version "<ocs_api_version>"
And group "grp" has been created
And user "Brian" has been added to group "grp"
Expand All @@ -71,13 +71,13 @@ Feature: share resources where the sharee receives the share in multiple ways
And as "Brian" folder "Shares/sharedParent" should not exist
And as "Brian" file "Shares/sharedParent/child/lorem.txt" should not exist
And as "Brian" file "Shares/parent/child/lorem.txt" should exist
Then user "Brian" should not be able to delete file "Shares/parent/child/lorem.txt"
And user "Brian" should not be able to delete file "Shares/parent/child/lorem.txt"
Examples:
| ocs_api_version |
| 1 |
| 2 |

Scenario Outline:Share reciever renames a group share and recieves same resource through user share with additional permissions
Scenario Outline:Share receiver renames a group share and receives same resource through user share with additional permissions
Given using OCS API version "<ocs_api_version> "
And group "grp" has been created
And user "Brian" has been added to group "grp"
Expand All @@ -94,7 +94,7 @@ Feature: share resources where the sharee receives the share in multiple ways
And as "Brian" folder "Shares/sharedParent" should not exist
And as "Brian" file "Shares/sharedParent/child/lorem.txt" should not exist
And as "Brian" file "Shares/parent/child/lorem.txt" should exist
Then user "Brian" should not be able to delete file "Shares/parent/child/lorem.txt"
And user "Brian" should not be able to delete file "Shares/parent/child/lorem.txt"
Examples:
| ocs_api_version |
| 1 |
Expand Down

0 comments on commit 0efa76b

Please sign in to comment.