Remove PollJob support #8398
Merged
Remove PollJob support #8398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
force-pushed
the
work/remove_poll_job
branch
from
e06c81c to
dbc0003
Compare
TheOneRing
force-pushed
the
work/remove_poll_job
branch
from
dbc0003 to
ac0a3ac
Compare
TheOneRing
requested review from
dragotin and
dschmidt
and removed request for
dragotin
|
Kudos, SonarCloud Quality Gate passed! |
|
Would have been nice to keep it :-( But also good to see code cleaner |
|
In the current implementation remotePermissions are not properly handled. client/src/libsync/discoveryphase.cpp Line 177 in 7d11079 I discovered it in #8076 where I tried to prevent empty permissions. For oci a different approach is planned. |
dschmidt
approved these changes
Feb 11, 2021
This was referenced Mar 8, 2021
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.