Propagator: Fix finished signal of directory being emited twice and c… #5579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ogoffart, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jturcotte, @ckamm and @dragotin to be potential reviewers. |
jturcotte
approved these changes
Mar 6, 2017
src/libsync/owncloudpropagator.cpp
Outdated
| if (_state != Finished) { | ||
| _state = Finished; | ||
| emit finished(_hasError == SyncFileItem::NoStatus ? SyncFileItem::Success : _hasError); | ||
| } |
There was a problem hiding this comment.
Would it make sense to also avoid the DB update in that case?
Closed
…ausing crash When there is a FatalError, we ended up emiting the finished signal for the directory job several times, which would lead to crashes Issue #5578
ogoffart
force-pushed
the
fix-abort-crash
branch
from
2794873 to
bb02dd3
Compare
|
@jturcotte patch updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ausing crash
When there is a FatalError, we ended up emiting the finished signal for
the directory job several times, which would lead to crashes
Issue #5578