fix: http header keys are case in-sensitive #11994
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepDiver1975
force-pushed
the
fix/httplogger-content-type-qt6.5
branch
from
9ace928
to
67d9257
Compare
saw-jan
reviewed
Nov 29, 2024
There was a problem hiding this comment.
we also have to change qt version here. so that owncloudci/squish comes with qt6.7 in PR owncloud-ci/squish#66
we use this owncloudci/squish image to build client and run GUI test against it. So client needs to be built with qt6.7 to work with squish8.0.0-qt67x
Lines 115 to 118 in 83d7be7
There was a problem hiding this comment.
And we need qt6.7.x in this squish path
https://download.owncloud.com/desktop/craft/cache/6.0/Qt_6.8.0_0/squish/linux/gcc/x86_64/RelWithDebInfo/libs/
maybe we can copy this: https://download.owncloud.com/desktop/craft/cache/6.0/Qt_6.7.3_0/linux/gcc/x86_64/RelWithDebInfo/libs/qt6/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qt6.7 compatible variant of #11993
requires: owncloud-ci/squish#66