Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup systray menu #10949

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Cleanup systray menu #10949

merged 2 commits into from
Jun 22, 2023

Conversation

TheOneRing
Copy link
Contributor

@TheOneRing TheOneRing commented Jun 20, 2023 •
edited
Loading

Fixes: #10939

image
image

@TheOneRing TheOneRing requested a review from a team June 20, 2023 14:34
@TheOneRing
Copy link
Contributor Author

When merged OWNCLOUD_MINIMAL_TRAY_MENU needs to be removed from the doc.

michaelstingl added a commit to owncloud/docs-client-desktop that referenced this pull request Jun 20, 2023
@michaelstingl
deprecate OWNCLOUD_MINIMAL_TRAY_MENU in 5.0
cf9aab9 
PR:
- owncloud/client#10949 (comment)
@michaelstingl michaelstingl mentioned this pull request Jun 20, 2023
Merged
@michaelstingl
Copy link
Contributor

When merged OWNCLOUD_MINIMAL_TRAY_MENU needs to be removed from the doc.

PR

@mmattel
Copy link
Contributor

mmattel commented Jun 20, 2023

I see two images but I cant identify the so called minimal tray menu. I want to double check if we have used screenshots in the docs that we need to remove too. Can one help with before/after images?

@TheOneRing
Copy link
Contributor Author

I see two images but I cant identify the so called minimal tray menu. I want to double check if we have used screenshots in the docs that we need to remove too. Can one help with before/after images?

Feel free to test OWNCLOUD_MINIMAL_TRAY_MENU locally.

fmoc
fmoc approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@fmoc fmoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Approving so you can merge. Please consider my one suggestion.

changelog/unreleased/10939 Outdated Show resolved Hide resolved
@TheOneRing TheOneRing merged commit 33b9bbe into master Jun 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the work/systray branch June 22, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmoc fmoc fmoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update system tray menu
4 participants
@TheOneRing @michaelstingl @mmattel @fmoc